kiwicom / the-zoo

πŸ’ A service registry for humans
MIT License
92 stars 6 forks source link

feat: zoo search #392

Closed gjuro87 closed 3 years ago

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts when merging c483f1a4c8d1f55574c027e39e811107fa4760b7 into dc46c732c3b72de5664e3dc1fa9712c1ec9b6377 - view on LGTM.com

new alerts:

ghost commented 3 years ago

Congratulations :tada:. DeepCode analyzed your code in 3.095 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

πŸ‘‰ View analysis in DeepCode’s Dashboard | Configure the bot

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.05%.

Quality metrics Before After Change
Complexity 2.01 ⭐ 2.13 ⭐ 0.12 πŸ‘Ž
Method Length 49.56 ⭐ 56.16 ⭐ 6.60 πŸ‘Ž
Working memory 12.91 😞 13.62 😞 0.71 πŸ‘Ž
Quality 70.74% πŸ™‚ 68.69% πŸ™‚ -2.05% πŸ‘Ž
Other metrics Before After Change
Lines 1297 1217 -80
Changed files Quality Before Quality After Quality Change
zoo/api/query.py 68.06% πŸ™‚ 64.15% πŸ™‚ -3.91% πŸ‘Ž
zoo/api/types.py 85.42% ⭐ 85.86% ⭐ 0.44% πŸ‘
zoo/base/apps.py 59.40% πŸ™‚ 59.40% πŸ™‚ 0.00%
zoo/base/settings.py 30.63% 😞 30.63% 😞 0.00%
zoo/base/urls.py 44.16% 😞 44.16% 😞 0.00%
zoo/libraries/views.py 76.90% ⭐ 78.07% ⭐ 1.17% πŸ‘
zoo/services/views.py 74.96% πŸ™‚ 75.41% ⭐ 0.45% πŸ‘

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zoo/api/query.py Query.resolve_all_search_results 4 ⭐ 158 😞 15 😞 50.24% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
zoo/base/apps.py BaseConfig.ready 0 ⭐ 149 😞 12 😞 59.40% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
zoo/libraries/views.py LibraryList.get_queryset 8 ⭐ 113 πŸ™‚ 10 😞 59.42% πŸ™‚ Extract out complex expressions
zoo/services/views.py ServiceList.get_queryset 8 ⭐ 113 πŸ™‚ 10 😞 59.42% πŸ™‚ Extract out complex expressions
zoo/api/query.py Query._objects_from_result 6 ⭐ 102 πŸ™‚ 11 😞 60.90% πŸ™‚ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

28.3% 28.3% Coverage
2.8% 2.8% Duplication