Closed gjuro87 closed 3 years ago
Congratulations :tada:. DeepCode analyzed your code in 3.095 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.
β Merging this PR will decrease code quality in the affected files by 2.05%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.01 β | 2.13 β | 0.12 π |
Method Length | 49.56 β | 56.16 β | 6.60 π |
Working memory | 12.91 π | 13.62 π | 0.71 π |
Quality | 70.74% π | 68.69% π | -2.05% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1297 | 1217 | -80 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
zoo/api/query.py | 68.06% π | 64.15% π | -3.91% π |
zoo/api/types.py | 85.42% β | 85.86% β | 0.44% π |
zoo/base/apps.py | 59.40% π | 59.40% π | 0.00% |
zoo/base/settings.py | 30.63% π | 30.63% π | 0.00% |
zoo/base/urls.py | 44.16% π | 44.16% π | 0.00% |
zoo/libraries/views.py | 76.90% β | 78.07% β | 1.17% π |
zoo/services/views.py | 74.96% π | 75.41% β | 0.45% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/api/query.py | Query.resolve_all_search_results | 4 β | 158 π | 15 π | 50.24% π | Try splitting into smaller methods. Extract out complex expressions |
zoo/base/apps.py | BaseConfig.ready | 0 β | 149 π | 12 π | 59.40% π | Try splitting into smaller methods. Extract out complex expressions |
zoo/libraries/views.py | LibraryList.get_queryset | 8 β | 113 π | 10 π | 59.42% π | Extract out complex expressions |
zoo/services/views.py | ServiceList.get_queryset | 8 β | 113 π | 10 π | 59.42% π | Extract out complex expressions |
zoo/api/query.py | Query._objects_from_result | 6 β | 102 π | 11 π | 60.90% π | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
SonarCloud Quality Gate failed.
This pull request introduces 4 alerts when merging c483f1a4c8d1f55574c027e39e811107fa4760b7 into dc46c732c3b72de5664e3dc1fa9712c1ec9b6377 - view on LGTM.com
new alerts: