Open jarosevcik opened 3 years ago
❌ Merging this PR will decrease code quality in the affected files by 3.12%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
Method Length | 50.96 ⭐ | 52.25 ⭐ | 1.29 👎 |
Working memory | 8.63 🙂 | 9.57 🙂 | 0.94 👎 |
Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 4652 | 3809 | -843 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
zoo/repos/tasks.py | 64.90% 🙂 | 66.55% 🙂 | 1.65% 👍 |
zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
❌ Merging this PR will decrease code quality in the affected files by 3.12%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
Method Length | 50.96 ⭐ | 52.25 ⭐ | 1.29 👎 |
Working memory | 8.63 🙂 | 9.57 🙂 | 0.94 👎 |
Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 4652 | 3809 | -843 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
zoo/repos/tasks.py | 64.90% 🙂 | 66.55% 🙂 | 1.65% 👍 |
zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
This pull request fixes 1 alert when merging 54c719716ac8f6ddf68c9d9777db3b54a49b88d4 into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
❌ Merging this PR will decrease code quality in the affected files by 3.12%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
Method Length | 50.96 ⭐ | 52.25 ⭐ | 1.29 👎 |
Working memory | 8.63 🙂 | 9.57 🙂 | 0.94 👎 |
Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 4652 | 3809 | -843 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
zoo/api/types.py | 86.50% ⭐ | 87.21% ⭐ | 0.71% 👍 |
zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
zoo/repos/tasks.py | 64.90% 🙂 | 66.55% 🙂 | 1.65% 👍 |
zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
This pull request fixes 1 alert when merging 3fb5995051e4aadd55398ef06cd06824bfc04baa into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
❌ Merging this PR will decrease code quality in the affected files by 3.12%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.40 ⭐ | 2.37 ⭐ | -0.03 👍 |
Method Length | 50.96 ⭐ | 52.26 ⭐ | 1.30 👎 |
Working memory | 8.63 🙂 | 9.58 🙂 | 0.95 👎 |
Quality | 74.15% 🙂 | 71.03% 🙂 | -3.12% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 4652 | 3810 | -842 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
test/conftest.py | 82.19% ⭐ | 78.83% ⭐ | -3.36% 👎 |
test/api/query/test_node.py | 80.74% ⭐ | 80.74% ⭐ | 0.00% |
test/api/query/test_service_environments.py | 88.68% ⭐ | 88.68% ⭐ | 0.00% |
test/api/query/test_services.py | 86.36% ⭐ | 87.45% ⭐ | 1.09% 👍 |
test/api/query/snapshots/snap_test_node.py | 76.49% ⭐ | 76.49% ⭐ | 0.00% |
test/api/query/snapshots/snap_test_services.py | 51.92% 🙂 | 52.04% 🙂 | 0.12% 👍 |
test/globalsearch/test_indexer.py | 80.21% ⭐ | 80.87% ⭐ | 0.66% 👍 |
test/globalsearch/test_utils.py | 85.69% ⭐ | 85.69% ⭐ | 0.00% |
zoo/factories.py | 51.89% 🙂 | 42.70% 😞 | -9.19% 👎 |
zoo/api/query.py | 66.22% 🙂 | 67.46% 🙂 | 1.24% 👍 |
zoo/api/schema.py | 84.39% ⭐ | 83.10% ⭐ | -1.29% 👎 |
zoo/api/types.py | 86.50% ⭐ | 87.19% ⭐ | 0.69% 👍 |
zoo/base/apps.py | 65.09% 🙂 | 65.09% 🙂 | 0.00% |
zoo/base/settings.py | 36.83% 😞 | 36.83% 😞 | 0.00% |
zoo/base/management/commands/generatezooyml.py | 82.43% ⭐ | 82.43% ⭐ | 0.00% |
zoo/base/templatetags/utils.py | 86.02% ⭐ | 86.02% ⭐ | 0.00% |
zoo/checklists/views.py | 66.51% 🙂 | 66.51% 🙂 | 0.00% |
zoo/libraries/models.py | 93.81% ⭐ | 93.48% ⭐ | -0.33% 👎 |
zoo/libraries/urls.py | 87.49% ⭐ | 91.89% ⭐ | 4.40% 👍 |
zoo/libraries/views.py | 81.08% ⭐ | 78.84% ⭐ | -2.24% 👎 |
zoo/repos/tasks.py | 64.90% 🙂 | 66.55% 🙂 | 1.65% 👍 |
zoo/repos/utils.py | 50.67% 🙂 | 54.06% 🙂 | 3.39% 👍 |
zoo/services/constants.py | 93.42% ⭐ | 93.42% ⭐ | 0.00% |
zoo/services/models.py | 77.56% ⭐ | 79.82% ⭐ | 2.26% 👍 |
zoo/services/urls.py | 86.08% ⭐ | 90.40% ⭐ | 4.32% 👍 |
zoo/services/views.py | 77.36% ⭐ | 75.98% ⭐ | -1.38% 👎 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
zoo/repos/utils.py | download_repository.openapi_definition | 22 😞 | 246 ⛔ | 13 😞 | 31.00% 😞 | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos.sync_entity_file.update_or_create_components.sync_enviroments_from_gitlab | 7 ⭐ | 161 😞 | 13 😞 | 49.70% 😞 | Try splitting into smaller methods. Extract out complex expressions |
zoo/api/query.py | Query.resolve_all_search_results | 4 ⭐ | 149 😞 | 13 😞 | 53.85% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
zoo/repos/tasks.py | sync_repos | 14 🙂 | 151 😞 | 8 🙂 | 53.85% 🙂 | Try splitting into smaller methods |
zoo/services/models.py | Service.rate_according_to_sentry | 1 ⭐ | 125 😞 | 16 ⛔ | 55.77% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
This pull request fixes 1 alert when merging 4886e07d2d2438bc27d0ad8b22fad90bb6bfbe0a into fee0108ea7b65112e5b572a146cff4b1c54033fd - view on LGTM.com
fixed alerts:
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
3 Security Hotspots
2 Code Smells
73.0% Coverage
0.0% Duplication