Hello,
we tried to implement your module in one of our shops. Installing over composer worked fine and all functionality seems to be there, but two of the Unit tests keep failing.
Besides that the module is really great, helps alot.
Preconditions
PHP version: 7.1.23
mysql Ver 14.14 Distrib 5.7.24, for Linux (x86_64) using EditLine wrapper
Magento: 2.3.0
PHP Unit: 6.5.13
Steps to reproduce
Running the Unit tests
Expected result
Passing of the Unit tests.
The problem seems to be that the tested function only returns an object or true, but the test expects it to be null.
SaveAfterTests fail on AssertNull
Hello, we tried to implement your module in one of our shops. Installing over composer worked fine and all functionality seems to be there, but two of the Unit tests keep failing.
Besides that the module is really great, helps alot.
Preconditions
Steps to reproduce
Running the Unit tests
Expected result
Passing of the Unit tests. The problem seems to be that the tested function only returns an object or true, but the test expects it to be null.
Actual result
Error log: 1) - KiwiCommerce\AdminActivity\Test\Unit\Observer\SaveAfterTest::testExecute