search

kiwigrid / gherkin-testcafe

Run testcafe tests with gherkin syntax
MIT License
69 stars 2 forks source link

Add support for state management of steps #42

Closed dobogo closed 5 years ago

dobogo commented 5 years ago

This PR supports for sharing state between step definitions which is cucumber's feature. https://cucumber.io/docs/cucumber/step-definitions/#state-management

Same as cucumber, state can be shared via this of a step function.

Lukas-Kullmann commented 5 years ago

Hey @dobogo,

thanks for your PR! But I don't really want to merge this since TestCafé already supports something like this out of the box via t.ctx and t.fixtureCtx (See here and here).

This package is supposed to bring gherkin features to TestCafé.

We want to support as many gherkin features as possible. Cucumber on the other hand is only used to conveniently compile the steps. We want to rely on TestCafé when it comes to testing features and data flow and try to avoid mixing cucumber and TestCafé concepts as much as possible.

dobogo commented 5 years ago

Hi @Lukas-Kullmann, I agree with you and understand you want to support gherkin features not cucumber. It is good for me to use t.ctx. Thanks for your clarification!