improve tag handling (closes kiwigrid#52)

kiwigrid / gherkin-testcafe

Run testcafe tests with gherkin syntax

MIT License

69 stars 2 forks source link

Closed Arthy000 closed 4 years ago

Arthy000 commented 4 years ago

Allows users to use an AND operator between tags.

Example:

@tag1 @tag2
Scenario1: ...

@tag1
Scenario2: ...

@tag2
Scenario3: ...

Using runner.tags('@tag1','@tag2'), all 3 scenarios would run. Using runner.tags('@tag1 and @tag2'), only Scenario1 would run. Will also work in CLI

--tags "@tag1 and @tag2"

Arthy000 commented 4 years ago

Did you use "" quotes? Otherwise the spaces make it look like you are switching to the next argument and you only use --tags ~@tag1

Lukas-Kullmann commented 4 years ago

Oh, sorry. Yes, I used quotes. :) I updated the comment.

Arthy000 commented 4 years ago

Gosh you're right, I see why this happens :(

Arthy000 commented 4 years ago

Hi Lukas, I made a few modifications, it should work better now :)

Arthy000 commented 4 years ago

Hi @Lukas-Kullmann

Do you need any other changes? If you don't, when do you think a new version will be released with my changes included? :)

Lukas-Kullmann commented 4 years ago

Sorry for letting you wait for so long. I published your changes in v2.5.0