kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
186 stars 209 forks source link

log_es_400_reason and request_timeout are not accepted config #281

Closed gadelkareem closed 4 years ago

gadelkareem commented 4 years ago

Is this a request for help?: No

How to reproduce it (as minimally and precisely as possible): add this config to

<match raw.kubernetes.**>
      @id raw.kubernetes
      @type detect_exceptions
      @log_level debug
      remove_tag_prefix raw
      message log
      stream stream
      multiline_flush_interval 5
      max_bytes 500000
      max_lines 1000
      request_timeout 15s
      log_es_400_reason true
    </match>

the log will warn about there params log_es_400_reason and request_timeout. And the will be ignored

monotek commented 4 years ago

Could you provide a pr for this please which makes it possible to enable this by values.yaml?

gadelkareem commented 4 years ago

I meant adding the two params to https://github.com/kiwigrid/helm-charts/blob/master/charts/fluentd-elasticsearch/templates/configmaps.yaml#L148 would produce a warning.

bauer01 commented 4 years ago

@gadelkareem it's wrong section...you should place log_es_400_reason true in output.conf.

For example here https://github.com/kiwigrid/helm-charts/blob/master/charts/fluentd-elasticsearch/templates/configmaps.yaml#L515 ;-)