kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

Use chart-testing-action with Helm v2.4.0 #319

Closed muffix closed 4 years ago

muffix commented 4 years ago

What this PR does / why we need it:

Currently, all helm-install checks are failing. This addresses the issue by changing the branch of the chart-testing-action to dev-v2 which provides support for Helm 2. Helm 3, which is the new default, introduces breaking changes.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Alternatively, we could add the unit to the config here, but we'd be pulling in Helm 3 with several breaking changes.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

monotek commented 4 years ago

fixed with: https://github.com/kiwigrid/helm-charts/commit/f4e5dbad111bc3470fbebd2bc12a47470b3ec273