kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

[prometheus-thanos] Fix syntax when opting in to binary index headers #322

Closed muffix closed 4 years ago

muffix commented 4 years ago

What this PR does / why we need it:

Fixes a bug where the template incorrectly chomps whitespace on the right and by that swallows a newline character and makes the rendered object invalid. When opting in to binary index headers, the broken chart merges the flag --experimental.enable-index-header and the next line, ports: into one: --experimental.enable-index-headerports:

This fixes it.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

monotek commented 4 years ago

Thanks for the PR. Merged :)