[fluentd-elasticsearch] Allow multiple hosts in config

samuel-begin commented 4 years ago

@axdotl
@monotek

What this PR does / why we need it:

Since Fluentd config accepts multiple hosts in its config, I would like to be able to provide them through the chart. The new hosts array parameter allow for multiple elasticsearch hosts to be configured as target.

Deprecated both parameters

elasticsearch:
  host: elasticsearch-client
  port: 9200

in favor of

elasticsearch:
  hosts: ["elasticsearch-client:9200"]

If you are using the AWS Sidecar, only the first host in the array is used. Aws-es-proxy is limited to one endpoint.

Which issue this PR fixes

fixes #330

Special notes for your reviewer:

I could not test changes done to the aws-es-proxy sidecar, if someone can help me with that part

Checklist

[x] DCO signed
[x] Chart Version bumped (if the pr is an update to an existing chart)
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

Ghazgkull commented 4 years ago

Since this was pushed out as a breaking change rather than a deprecation, all clients will have to update to the new syntax when the upgrade to the new major version.

With this in mind, would someone mind updating the README explaining how to specify this property as a --set parameter now? i.e. How do we update from something like helm template xyz kiwigrid/fluentd-elasticsearch --set elasticsearch.host=foo.com?

Ghazgkull commented 4 years ago

I opened an issue for this and I'll submit a PR shortly. https://github.com/kiwigrid/helm-charts/issues/336

kiwigrid / helm-charts