graphite - expose carbon UDP port

kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid

https://kiwigrid.github.io

MIT License

184 stars 210 forks source link

graphite - expose carbon UDP port #335

Closed jverhoeven closed 4 years ago

jverhoeven commented 4 years ago

Added missing UDP port for plain carbon interface on port 2003 in statefullset and services. This UDP interface needs to be enabled by setting option

ENABLE_UDP_LISTENER = True

in carbon.conf in the values.yaml.

It is still one of the best interfaces for pushing bulk amounts of metrics in, if you don't care about guaranteed delivery.

I tested the modifications in my own cluster and it works fine. Also, can still telnet to 2003 TCP port.

Checklist

[x] DCO signed
[x] Chart Version bumped (if the pr is an update to an existing chart)
[x] Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

jverhoeven commented 4 years ago

As this is a new feature chart version should be raised to 0.6.0.

Will do.

Maybe you could also update the docker image to the latest version 1.1.7-2?

Good idea, see current version is 1.1.5-4, year old, but the change is non-trivial given 1 year of changes. Prefer to keep it separate.

monotek commented 4 years ago

Good idea, see current version is 1.1.5-4, year old, but the change is non-trivial given 1 year of changes. Prefer to keep it separate.

Regarding to the version change and having semver in mind, this should be a non breaking change / only bugfixes. But to be honest i did not checked it. So maybe its better to do the update seperatly.

We don't us graphite anymore as we switched to prometheus completly. If you try the image update later it would be nice you could give us some feedback if its safe to update the chart.

P.S: please merge master in your branch too.