kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

[fluentd-elasticsearch] Update README.md to explain --set syntax change for 8.0 #337

Closed Ghazgkull closed 4 years ago

Ghazgkull commented 4 years ago

What this PR does / why we need it:

This PR adds to the documentation for upgrading to version 8.x of this chart, advising how to handle the elasticsearch.host/port change using --set

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Chart version not bumped because this is a documentation change only.

Ghazgkull commented 4 years ago

@monotek The build failed because I didn’t bump the chart version. I’m not sure what your policy is... can you accept a README change like this? Or would you prefer to bump the chart version?

monotek commented 4 years ago

And please merge master before raising the version.

monotek commented 4 years ago

@Ghazgkull

please rebase / raise cahrt version & sign dco.