kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
186 stars 209 forks source link

fix(labels): remove deprecated label #344

Closed azman0101 closed 4 years ago

azman0101 commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST? : FEATURE REQUEST

Version of Helm and Kubernetes: Helm v3.1.2 and Kubernetes v1.15.9

Which chart in which version: 9.0.0

What happened:

What this PR does / why we need it:

Avoid diff in our CI because of k8s removing this label deprecated label constantly.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

azman0101 commented 4 years ago

@monotek because you are using kind: apps/v1 for the daemonset which is not compatible with k8s 1.6 and previous version.

Migrate to use the apps/v1 API version, available since v1.9

azman0101 commented 4 years ago

I've change this MR as you asked.

azman0101 commented 4 years ago

We notice that semverCompare is not working as expected for version with a pre-release like

v1.15.11-gke.5 or v1.16.8-eks-e16311

So we need to strip this part

azman0101 commented 4 years ago

Hello @monotek, I've made the changes you asked.