kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

[fluentd-elasticsearch] Provide option to disable settings elasticsearch hosts #350

Closed ArmaanT closed 4 years ago

ArmaanT commented 4 years ago

What this PR does / why we need it:

This PR provides a way to disable setting the OUTPUT_HOSTS environment variable from the elasticsearch.hosts value. This feature allows users to manually set OUTPUT_HOSTS using a secret or alternative method if they desire.

Which issue this PR fixes

Special notes for your reviewer:

N/A

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

ArmaanT commented 4 years ago

@monotek I changed the name over to useOutputHostEnvVar, but I think something like setOutputHostEnvVar may make more sense, because then a false value means the chart won't set that environment variable.