kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

nil pointer evaluating interface {}.KubeVersion #358

Closed mchesnut closed 4 years ago

mchesnut commented 4 years ago

Is this a request for help?: Yes, need help understanding the cause of this issue. May be a bug report as well.


Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug report

Version of Helm and Kubernetes: Helm: version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

Kubernetes: 1.16.8-gke.15 (Google Kubernetes Engine)

Which chart in which version: fluentd-elasticsearch, currently published public version (9.3.0)

What happened: When attempting to apply the fluentd-elasticsearch chart, I get an error: $ helm upgrade fluentd kiwigrid/fluentd-elasticsearch -f ./fluentd-values.yaml Error: UPGRADE FAILED: template: fluentd-elasticsearch/templates/service.yaml:4:48: executing "fluentd-elasticsearch/templates/service.yaml" at <.Capabilities.KubeVersion.GitVersion>: nil pointer evaluating interface {}.KubeVersion

What you expected to happen: I expect the chart to be applied successfully.

How to reproduce it (as minimally and precisely as possible): $ helm upgrade fluentd kiwigrid/fluentd-elasticsearch

Anything else we need to know: In troubleshooting this, I've noticed that GitVersion is deprecated. It is no longer listed at https://helm.sh/docs/chart_template_guide/builtin_objects/ and I see this mentioned here: https://github.com/helm/helm/blob/2f4ef705a9e8ea0e38a2c99c29c5e4de59b03d75/pkg/chartutil/capabilities.go#L60

I cloned the repo and tried using Version instead of GitVersion, thinking this to be the problem, but the behavior did not change.

If I scope the $striped_version definition to be global (by prepending $), then everything works as I'd expect. Here's a diff comparing current master to my local branch that works successfully: https://github.com/mchesnut/helm-charts/commit/a69a2787a8b2d88031632eeac7196980a4ea56da

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.