kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

[fluentd-elasticsearch] (PREVIEW - DO NOT MERGE) Add suppressTypeName parameter to eliminate ES 7 deprecation warnings #384

Closed Ghazgkull closed 4 years ago

Ghazgkull commented 4 years ago

What this PR does / why we need it:

This PR adds elasticsearch.suppressTypeName as a chart parameter in order to leverage the suppress_type_name option on the fluentd-elasticsearch plugin.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Please note that this PR will not work at this moment! At the time this PR is being opened, the referenced fluend-elasticsearch image version (3.0.4) is in PR but not yet been published. (https://github.com/kubernetes/kubernetes/pull/93116)

I'm submitting this PR now so it can be reviewed and I can incorporate any feedback as needed.

Note that I have tested both the new fluentd-elasticsearch image 3.0.4 (published as a fork) as well as the changes I'm submitting here (published to a private helm repo), so I'm confident that everything will work once the k8s PR has been merged.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Ghazgkull commented 4 years ago

PR comments addressed. New commit pushed.

monotek commented 4 years ago

I've just pushed image 3.0.4. https://quay.io/repository/fluentd_elasticsearch/fluentd?tab=tags