kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
186 stars 209 forks source link

[prometheus-thanos] minio ghost requirements #397

Closed Antiarchitect closed 4 years ago

Antiarchitect commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

BUG REPORT

Version of Helm and Kubernetes:

helm version:
version.BuildInfo{Version:"v3.3.1", GitCommit:"249e5215cde0c3fa72e27eb7a30e8d55c9696144", GitTreeState:"clean", GoVersion:"go1.14.7"}

kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:12:48Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:04:18Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

Which chart in which version: https://hub.helm.sh/charts/kiwigrid/prometheus-thanos/4.5.0

What happened: Trying to install promtheus-thanos and provide MinIO by myself. Getting this error:

[ERROR] templates/: template: app-thanos/charts/prometheus-thanos/charts/minio/templates/deployment.yaml:194:20: executing "app-thanos/charts/prometheus-thanos/charts/minio/templates/deployment.yaml" at <(not .Values.gcsgateway.enabled) (not .Values.azuregateway.enabled) (not .Values.s3gateway.enabled) (not .Values.b2gateway.enabled)>: can't give argument to non-function not .Values.gcsgateway.enabled

What you expected to happen: Thanos runs with external MinIO - no built-in minio parts are deployed

How to reproduce it (as minimally and precisely as possible): Create a head chart, add these dependencies in Chart.yaml:

dependencies:
- name: prometheus-thanos
  alias: thanos
  version: 4.5.0
  repository: https://kiwigrid.github.io/
- name: minio
  version: 6.0.5
  repository: https://helm.min.io/

Anything else we need to know: Your chart packed version (4.5.0) do actually contain minio chart inside - seems like a packing error.