kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

Using base64 to encrypt the data to base64 while installing the helm chart #402

Closed Anurag-30 closed 3 years ago

Anurag-30 commented 4 years ago

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

monotek commented 4 years ago

Please add the changes requested in: https://github.com/kiwigrid/helm-charts/pull/401

By the way... You can just change the pr by pushing into the branch again. No need to open a new pr :)

Anurag-30 commented 3 years ago

Please fix yaml lint: https://github.com/kiwigrid/helm-charts/pull/402/checks?check_run_id=1153090800

and sign dco: https://github.com/kiwigrid/helm-charts/pull/402/checks?check_run_id=1153089862

can you help me fixing this. I ran helm lint in local and it's working fine. The log said remove trailing spaces I have done that yet it exits with an error

monotek commented 3 years ago

fixed the values by adding quotes but you have to fix the dco: https://github.com/kiwigrid/helm-charts/pull/402/checks?check_run_id=1162981244

monotek commented 3 years ago

@Anurag-30 Could you please follow the instructions of:
https://github.com/kiwigrid/helm-charts/pull/402/checks?check_run_id=1162981244

Anurag-30 commented 3 years ago

https://github.com/kiwigrid/helm-charts/pull/402/checks?check_run_id=1162981244

I have followed the instructions and pushed it

monotek commented 3 years ago

What happenend here? There are changes for 3 different charts now?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.