kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
186 stars 209 forks source link

[prometheus-thanos] Wrap all thanos additional args in quotes #420

Closed iemre closed 3 years ago

iemre commented 3 years ago

What this PR does / why we need it:

This allows us to pass additional flags that have new line characters and/or quotation marks in them. One specific example of this is the "tracing.config" flag that takes a YAML string that may contain new line characters, spaces and quotation marks. When this is the case, the provided YAML gets broken and becomes invalid.

We did this for Thanos Querier previously in https://github.com/kiwigrid/helm-charts/pull/419. This PR does the same for all Thanos components that accept additional args.

Signed-off-by: Emre Kartoglu iemrek@gmail.com

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

iemre commented 3 years ago

@monotek since you reviewed a similar PR previously I'm tagging you. Thanks!