search

kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

gcp-serviceaccount-controller CRD validation error: unknown field "validation" and unknown field "version" #422

Closed nicolasbelanger closed 3 years ago

nicolasbelanger commented 3 years ago

Is this a request for help?: yes, please. can't deploy the newest version 0.2.6

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG

Version of Helm and Kubernetes: helm 3.5.1 k8s 1.17.14

Which chart in which version: gcp-serviceaccount-controller 0.2.6

What happened: rendering the template does work, but error on helm diff: Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "validation" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): missing required field "versions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]

What you expected to happen: no error?! :) 0.2.5 does work correctly...

How to reproduce it (as minimally and precisely as possible): helm diff upgrade gcp-serviceaccount-controller kiwigrid/gcp-serviceaccount-controller --allow-unreleased --suppress-secrets --version 0.2.6 --namespace infra

Anything else we need to know:

rpahli commented 3 years ago

I'll have a look

rpahli commented 3 years ago

@nicolasbelanger can you pls retry it with version 0.3.0

nicolasbelanger commented 3 years ago

@rpahli Thanks for the quick release. Unfortunately, there are still issues with 0.3.0...

Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "validation" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]

So missing required field "versions" is fixed, but still erroring on unknown field "validation" + unknown field "version"...

rpahli commented 3 years ago

Ok I was a little bit to greedy with chanching the version to v1. Now it should work with 0.3.1.

nicolasbelanger commented 3 years ago

Yeah, now the diff passes 👍 Will try to deploy and test it soon. Thanks!