[prometheus-thanos] Add k8s Service for thanos compactor - Githubissues

kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid

https://kiwigrid.github.io

MIT License

184 stars 210 forks source link

[prometheus-thanos] Add k8s Service for thanos compactor #425

Closed iemre closed 3 years ago

iemre commented 3 years ago

Signed-off-by: Emre Kartoglu iemrek@gmail.com

Co-authored-by: Tony Di Nucci tony.dinucci@skyscanner.net

What this PR does / why we need it:

This adds a k8s Service definition for the Thanos Compactor component so we can monitor it using its HTTP /metrics endpoint.

This also adds a Service port mapping for the Thanos Receiver component for the same reason i.e. monitoring using the HTTP /metrics endpoint.

Special notes for your reviewer:

I've tested the changes in a local setup.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped (if the pr is an update to an existing chart)
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

iemre commented 3 years ago

Thanks for the review @monotek. I have just addressed your comment (pushed a new commit).