kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
186 stars 209 forks source link

[graphite] - Add option to disable expose of the carbon UDP port #434

Closed holubovskyi closed 3 years ago

holubovskyi commented 3 years ago

What this PR does / why we need it:

When using the graphite chart with the service type LoadBalancer and statsd interface type TCP in the GKE the following error occurs:

Error: Service "grafana-graphite" is invalid: ...
cannot create an external load balancer with mix protocols

This error occurs because GCP doesn't allow to configure load balancer with mix of the TCP and UDP protocols.

This PR adds the ability to disable exposing of the carbon UDP port by using service.enableCarbonUdpPort value.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

monotek commented 3 years ago

Please also sign your commits to fix the dco check

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.