kiwigrid / helm-charts

Helm charts for Kubernetes curated by Kiwigrid
https://kiwigrid.github.io
MIT License
184 stars 210 forks source link

[prometheus-thanos] Allow for Thanos Receiver service to be headless or not #437

Closed tdinucci closed 3 years ago

tdinucci commented 3 years ago

Signed-off-by: Tony Di Nucci tony.dinucci@skyscanner.net

What this PR does / why we need it:

Some systems (e.g. old versions of Istio) do not like headless services.

This PR updates the chart so that headless services are still the default for Receivers (so this is not a breaking change) however you can now configure things so that a standard service is created if you want.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.