search

kiwigrid / k8s-sidecar

This is a docker container intended to run inside a kubernetes cluster to collect config maps with a specified label and store the included files in a local folder.
MIT License
563 stars 181 forks source link

Support resource deletion with LIST(SLEEP) #313

Open hwan0079 opened 10 months ago

hwan0079 commented 10 months ago

This is related to issue - https://github.com/kiwigrid/k8s-sidecar/issues/311. There is bug when the resource is deleted with method - SLEEP.

ERROR:

Traceback (most recent call last):
  File "/app/resources.py", line 300, in _update_file
    return remove_file(dest_folder, filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/helpers.py", line 103, in remove_file
    complete_file = os.path.join(folder, filename)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 76, in join
TypeError: expected str, bytes or os.PathLike object, not NoneType
ChristianGeie commented 9 months ago

Thx for the PR, LGTM so far. But I would like to do some more test...

ns-phegde commented 7 months ago

Thx for the PR, LGTM so far. But I would like to do some more test...

@ChristianGeie Would you know when this feature will be supported? Thanks.

ChristianGeie commented 6 months ago

I thought about the SLEEP for a long time same for WATCH. Currently #326 looks good to me, so I would prefer that. @ns-phegde After implementing and some more tests I'll jump into your request.

ns-phegde commented 1 month ago

@ChristianGeie @jekkel Hope guys are well. Did you guys get some time discuss adding more tests so we can get this PR merged?

ChristianGeie commented 1 month ago

I have a lot to do at the moment and my reviewers are not available. I am grateful for any help.