kiwigrid / k8s-sidecar

This is a docker container intended to run inside a kubernetes cluster to collect config maps with a specified label and store the included files in a local folder.
MIT License
612 stars 183 forks source link

k8s-sidecar 1.25.2 CVE Finding Twistlock #314

Closed dpericaxon closed 9 months ago

dpericaxon commented 1 year ago

Hello! We ran a scan of the most recent version of the kiwi sidecar and got these findings:

CVE: CVE-2023-5752 Description: When installing a package from a Mercurial VCS URL (ie \"pip install hg+...\") with pip prior to v23.3, the specified Mercurial revision could be used to inject arbitrary configuration options to the \"hg clone\" call (ie \"--config\"). Controlling the Mercurial configuration can modify how and which repository is installed. This vulnerability does not affect users who aren\'t installing from Mercurial. Library: pip (METADATA) Severity: MEDIUM Installed version: 23.2.1
Fixed Version: 23.3 More info: https://nvd.nist.gov/vuln/detail/CVE-2023-5752

CVE:CVE-2023-45803 Title: urllib3 is a user-friendly HTTP client library for Python. urllib3 previously wouldn\'t remove the HTTP request body when an HTTP redirect response using status 301, 302, or 303 after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although this behavior is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers. Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren\'t putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn\'t exploitable. Both of the following conditions must be true to be affected by this vulnerability: 1. Using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON) and 2. The origin service is compromised and starts redirecting using 301, 302, or 303 to a malicious peer or the redirected-to service becomes compromised. This issue has been addressed in versions 1.26.18 and 2.0.7 and users are advised to update to resolve this issue Library: urllib3 (METADATA) Severity: MEDIUM Installed version: 2.0.6 Fixed Version: 2.0.7, 1.26.18 More info: https://nvd.nist.gov/vuln/detail/CVE-2023-45803

Any chance these will get bumped?

ChristianGeie commented 9 months ago

Thx for reporting and sorry for the late reply.

CVE-2023-5752 was fixed in k8s-sidecar:1.25.4 CVE-2023-45803 was fixed in k8s-sidecar:1.25.3