search

kiwigrid / k8s-sidecar

This is a docker container intended to run inside a kubernetes cluster to collect config maps with a specified label and store the included files in a local folder.
MIT License
563 stars 181 forks source link

Adding support for req-username-file and req-password-file cli flags #322

Closed wasim-nihal closed 3 months ago

wasim-nihal commented 7 months ago

Changes for https://github.com/kiwigrid/k8s-sidecar/issues/318

ChristianGeie commented 6 months ago

@wasim-nihal thx for contributing. lgtm so far. Can you please provide a little test for this use case?

wasim-nihal commented 6 months ago

Can you please provide a little test for this use case?

Sure, thanks for your review. I will add the test.

wasim-nihal commented 6 months ago

Hi @ChristianGeie , I have added tests for the change. Can you please trigger the test execution and let me know if something needs to be updated.

ChristianGeie commented 6 months ago

@wasim-nihal i triggered the checks but after a couple of minutes i cancel because of observing an "endless" loop while sidecar-basicauth-args becomes ready. I haven't had the chance to look at it in detail yet.

wasim-nihal commented 6 months ago

@ChristianGeie , I suspect the pod did not come up because the image name k8s-sidecar:testing was not found. I have corrected it in the latest commit with the right image kiwigrid/k8s-sidecar:testing . Could you please re-run it once?

ChristianGeie commented 6 months ago

Sure.

ChristianGeie commented 6 months ago

looks much better now

wasim-nihal commented 6 months ago

Thanks @ChristianGeie

wasim-nihal commented 3 months ago

@ChristianGeie, could you please let me know if any further changes are needed? I shall work on it.

ChristianGeie commented 3 months ago

@wasim-nihal i add k8s v1.29 in the meantime. So I start the tests again.

wasim-nihal commented 3 months ago

sure

ChristianGeie commented 3 months ago

@wasim-nihal workflow for checks did not start, can you do a empty commit followed by a git push pls?

wasim-nihal commented 3 months ago

@wasim-nihal workflow for checks did not start, can you do a empty commit followed by a git push pls?

Thanks, done rebsing. Workflows seem to have passed.