kiwigrid / k8s-sidecar

This is a docker container intended to run inside a kubernetes cluster to collect config maps with a specified label and store the included files in a local folder.
MIT License
612 stars 183 forks source link

support client certificates when communicating with REQ_URL #334

Open wasim-nihal opened 8 months ago

wasim-nihal commented 8 months ago

Presently, there is no provision to configure the client certificates in kiwigrid k8s sidecar when making a request to REQ_URL. But there are some cases where the server is required to validate the client (mTLS) which is the case in our organization.

So, it is better to add a support to configure the client certificate and client key by introducing two new environment variables namely REQ_CLIENT_CERT and REQ_CLIENT_KEY respectively that take the path to the corresponding files.

If the community feels that this feature would be help, I would like to open a PR for the same.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

wasim-nihal commented 1 month ago

Commenting to remove the stale label, as the PR https://github.com/kiwigrid/k8s-sidecar/pull/335 is currently under review.