search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
182 stars 65 forks source link

Force \r\n for all network rights, as per RFC #181

Closed halkeye closed 5 years ago

halkeye commented 5 years ago

as per https://github.com/insomniacslk/irc-slack/pull/56#issuecomment-451644740

IRC messages are always lines of characters terminated with a CR-LF (Carriage Return - Line Feed) pair, and these messages SHALL NOT exceed 512 characters in length, counting all characters including the trailing CR-LF.

So IRC spec says messages need to be \r\n, so quick patch to do so.

There doesn't seem to be a test that breaks with this.