search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
181 stars 64 forks source link

Fix cap negotiation not being set to true #188

Closed xPaw closed 5 years ago

xPaw commented 5 years ago

Meaning doing SASL auth would prevent CAP END from being sent.

This already prevented RPL_SASLLOGGEDIN from sending CAP END, and after #184 RPL_LOGGEDIN would no longer send one either.

I set it to true in LS, but since the condition is only checked in auth related numerics, I could put it in ACK before sending AUTHENTICATE.

Should probably also reset it to false when a new connection is opened?

prawnsalad commented 5 years ago

@xPaw resetting it on a new connection makes sense, yes. Also, negotiating = true in LS as you have it makes more sense as it's specifically relating to CAP negotiating, not auth.