kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
181 stars 64 forks source link

Add support for providing client TLS certificate #239

Closed xPaw closed 4 years ago

xPaw commented 4 years ago

Makes it possible to support certfp.

My pending code in TL: https://github.com/thelounge/thelounge/compare/xpaw/certfp

prawnsalad commented 4 years ago

The config options should be snake_case to be consistent with others. I haven't tested it so I'll leave it to you to test properly, but otherwise this looks ok to me.

xPaw commented 4 years ago

Hm, there's rejectUnauthorized is also not snake case.

prawnsalad commented 4 years ago

Hm yea, that one got through unfortunately. Going from the docs it should be the only one https://github.com/kiwiirc/irc-framework/blob/8ce8d2fcd661ab816378f842cf7b27a8e7900bef/docs/clientapi.md