kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
181 stars 64 forks source link

Use native brotli compression, move core-js and regenerator-runtime to devDependencies #257

Closed xPaw closed 3 years ago

xPaw commented 4 years ago

iltorb uses a native module that does not work on Windows on Node 14 for example. With Node 10.16.0+, CompressionPlugin works natively just fine.

I still don't understand what the point of including core-js and regenerator-runtime is, I believe it is for browser builds, but no idea what the use case of that is. As webpack builds them directly into browser.js, it should be safe to move them to devDeps.

As far as I know, they are not necessarily for node.js. As this change should only affect browser builds, I can't really test it myseslf.