search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
181 stars 63 forks source link

Move SOCKS support to a more maintained package (fixes timeout) #279

Closed Mstrodl closed 3 years ago

Mstrodl commented 3 years ago

Hi there, it seems socksjs is a dead package (archived repo) and wasn't even giving an actual net.Socket (which caused crashes when timeouts were enabled!). This PR changes SOCKS support to use the socks package which is more maintained and just seems generally better from what I've seen. Currently, it's hardcoded to only use SOCKSv5, but socks can support higher versions, I just didn't want to change the existing API.

xPaw commented 3 years ago

Can you fix eslint stuff please.

Mstrodl commented 3 years ago

@xPaw done :)

Mstrodl commented 3 years ago

@xPaw Could version be bumped and pushed to NPM?

xPaw commented 3 years ago

@MaxLeiter can you handle testing of this? As far I have seen there might be other changes that TL might want to get into a release.

Let me know whether you can make a release yourself here or whether I need to make one.

MaxLeiter commented 3 years ago

Yeah I can handle it

MaxLeiter commented 3 years ago

@Mstrodl are you on IRC? Mind stopping by #thelounge on irc.libera.chat and sending me a ping? (Or feel free to private message me, nick is MaxLeiter)

Mstrodl commented 3 years ago

@MaxLeiter I've poked you on IRC, I think we have some drastically different timezones... lol