Release workflow && Switch tests to using yarn

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.

MIT License

181 stars 63 forks source link

Release workflow && Switch tests to using yarn #286

Closed ItsOnlyBinary closed 3 years ago

ItsOnlyBinary commented 3 years ago

Looking at the existing npm packages I assume build is required as part of the release workflow.

MaxLeiter commented 3 years ago

not sure npm-run-all is necessary but that's a nitpick. Seems good to go

side-note: I don't think the 10.x test will pass due to it being removed in this PR, so checks will never complete.

ItsOnlyBinary commented 3 years ago

The switch to npm-run-all is because it plays nicer with yarn when running other scripts.

Stops this warning without having to add the flag:

npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1623082994367-0.6850914539890189/node but npm is using /opt/hostedtoolcache/node/14.17.0/x64/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.