search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
181 stars 63 forks source link

My configuration to avoid restoring it with each update #311

Closed Madriix closed 2 years ago

Madriix commented 2 years ago

So here I am making a request to update IRC Framework with my current configuration which I have to put back each time as soon as you update it. It would be nice if I could download each time with all of this already without having to add it each time.

If there is stuff you don't like, like the "UA" (user agent) you can remove it.

ItsOnlyBinary commented 2 years ago

I have modified your pr to only include RPL_EXCEPTLIST here: https://github.com/kiwiirc/irc-framework/pull/313

for the unhandled '531': 'ERR_CANTSENDTOUSER' i suggest you listen for 'unknown command' or create a middleware to listen for raw events, see here: middleware

for ERR_ERRONEOUSNICKNAME there is already an event here: https://github.com/kiwiirc/irc-framework/blob/master/src/commands/handlers/user.js#L139

for the user agent ctcp i suggest you implement it within your bot/client by listening for the 'ctcp request' event

Thank you for the contribution, Hope this extra info helps

Madriix commented 2 years ago

for ERR_ERRONEOUSNICKNAME there is already an event here: https://github.com/kiwiirc/irc-framework/blob/master/src/commands/handlers/user.js#L139

Ok thank you for warning, I removed it in my tests and in production I would do it tomorrow morning because right now it's rush hour, there are just two blocks to modify, one on irc framework and one on the irc client web