search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
180 stars 62 forks source link

irc-framework mishandles RPL_WHOSPCRPL #331

Closed MaxLeiter closed 1 year ago

MaxLeiter commented 2 years ago

cc @SadieCat @PolarizedIons

from IRC:

13:22 <Sadie> what you're supposed to do for whox matching is give it a token (flag t) and then use that token in the response  to work out what parameters the server responded with 
13:24 <Sadie> for the record- inspircds whox implementation was written based on snircd readme.who which has a last edited date of 02 Jan 1999, ircv3s is based on that
16:30 <itsonlybinary> tracking the request would be the only way to support custom whox params
16:30 <itsonlybinary> it would also involve parsing outgoing messages and adding them to the event bus

relevant code: https://github.com/kiwiirc/irc-framework/blob/469cbe7b2129ddae0328a7efe91eb218257e98ff/src/commands/handlers/misc.js#L131-L144

https://github.com/kiwiirc/irc-framework/blob/af14f5a9fcd232e77899b7ad66508ac040746d55/src/client.js#L786

ItsOnlyBinary commented 1 year ago

This issue was resolved with #333