Add serialize_writes option to ensure lines are sent in-order (resolves #361)

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.

MIT License

180 stars 62 forks source link

Add serialize_writes option to ensure lines are sent in-order (resolves #361) #362

Open edfletcher opened 1 year ago

edfletcher commented 1 year ago

Resolves #361

Includes an integration test that exercises both option values, demonstrating that - without serialized_writes - lines that are purposefully reversed in order from that which the caller emitted them will be sent in that reverse order undesirably. When enabling serialized_writes, those writes are emitted in the order the caller intended.

I'll squash all commits in this PR down into one before merging.

edfletcher commented 1 year ago

For E2E testing, I am using this fix-fork already with my personal DRC instance(s), and it's working like a charm. Can't really think of a better way to E2E test it except for putting together a significant bot-and-mock-server-based test harness, which honestly I just don't have the time for.