search

kiwiirc / irc-framework

🛠️ A better IRC framework for node.js. For bots and full clients.
MIT License
180 stars 62 forks source link

Disable SASL as it is always testing it with PASS Command #374

Open Madriix opened 6 months ago

Madriix commented 6 months ago

Hi

I noticed that to disable SASL, I shouldn't remove this:

    account: {
        account: 'username',
        password: 'account_password',
    },

but I should leave 'account' and remove everything inside :

    account: {
    },

Isn't there another solution, like setting an option to 'false'? Or do I need to proceed as I indicated here?

Madriix commented 6 months ago

Finally, maybe with this it would work too, change this:

    account: {
    },

by account: true,

NOT false, see here https://github.com/kiwiirc/irc-framework/blob/master/src/commands/handlers/registration.js#L442

Furthermore, I find that the name account: {} is not very understandable, this name would be more suitable: sasl: {} or create something better like: 

    sasl: {
        enabled: false,
        account: 'username',
        password: 'account_password',
    },