search

kiwiirc / kiwibnc

Apache License 2.0
43 stars 14 forks source link

WHOIS responses get duplicated #20

Closed DanielOaks closed 5 years ago

DanielOaks commented 5 years ago

If you WHOIS someone, then WHOIS them again, you start getting each line duplicated multiple times, e.g.:

whois dan
:irc.example.com 311 dan-bnc dan ~textual 0::1 * :Textual User
:irc.example.com 319 dan-bnc dan @#test
:irc.example.com 671 dan-bnc dan :is using a secure connection
:irc.example.com 690 dan-bnc dan en :can speak these languages
:irc.example.com 317 dan-bnc dan 221 1559008237 :seconds idle, signon time
:irc.example.com 318 dan-bnc dan :End of /WHOIS list

whois dan
:irc.example.com 311 dan-bnc dan ~textual 0::1 * :Textual User
:irc.example.com 311 dan-bnc dan ~textual 0::1 * :Textual User
:irc.example.com 319 dan-bnc dan @#test
:irc.example.com 319 dan-bnc dan @#test
:irc.example.com 671 dan-bnc dan :is using a secure connection
:irc.example.com 690 dan-bnc dan en :can speak these languages
:irc.example.com 317 dan-bnc dan 222 1559008237 :seconds idle, signon time
:irc.example.com 317 dan-bnc dan 222 1559008237 :seconds idle, signon time
:irc.example.com 318 dan-bnc dan :End of /WHOIS list
:irc.example.com 318 dan-bnc dan :End of /WHOIS list

This continues, so if I WHOIS again I get three of every line, etc.

DanielOaks commented 5 years ago

Alright yeah, the message_to_clients hook of the ReplyRouter isn't properly taking clients off the expecting_replies list when it should be.

DanielOaks commented 5 years ago

Tiny change 867375ebde4de364ce01e454902cc89f2fc45491 fixed this. Would've PR'd it but it's literally just flicking the switch when it should obviously be flicked.