search

kiwiirc / kiwibnc

Apache License 2.0
44 stars 14 forks source link

"Load previous messages" element sometimes disappears after first click #44

Closed mestaritonttu closed 4 years ago

mestaritonttu commented 4 years ago

The element <a class="u-link">Load previous messages</a> sometimes goes away after loading previous messages once. It is not always reproducable. Let me know, if I can insert some logging code to help find out what happens.

prawnsalad commented 4 years ago

I've pushed to master a change that will ensure a message ID exists on incoming messages which should fix this for messages from this point forward - not for existing messages. If you could update your kiwibnc to git master when you get a chance and see how it goes for a week, hopefully it should be resolved.

mestaritonttu commented 4 years ago

Message loading now seems to be working robustly, thanks!

mestaritonttu commented 4 years ago

I celebrated too soon. Now I am getting this again consistently.

prawnsalad commented 4 years ago

There was some fiddly changes to the messagelist recently that cause a regression in master, but luckily we caught it here https://github.com/kiwiirc/kiwiirc/pull/1376