Ignoring CTCP communication means not logging emotes

kiwiirc / kiwibnc

Apache License 2.0

43 stars 14 forks source link

Ignoring CTCP communication means not logging emotes #51

Closed mestaritonttu closed 4 years ago

mestaritonttu commented 4 years ago

The mystery with missing messages in logs is solved: all /me emotes are dropped because CTCP requests/responses are ignored in src/worker/messagestores/flatfile.js and src/worker/messagestores/sqlite.js

prawnsalad commented 4 years ago

Good find! Now fixed in master :)

mestaritonttu commented 4 years ago

I tested and emotes are still not logged.

prawnsalad commented 4 years ago

Oops, looks like it was checking in the wrong place. I've just tested it in latest master and it's now storing ACTION emotes.