kiwionly / elasticsearch-image

Content Based Image Retrieval Plugin for Elasticsearch. It allows users to index images and search for similar images.
Apache License 2.0
46 stars 20 forks source link

Plans to support Elasticsearch >= 5.0? #20

Open nickstanisha opened 7 years ago

nickstanisha commented 7 years ago

Elasticsearch 5.0 has been released and this plugin has not yet been updated to support the new version. Are there plans to support future versions of ES?

My findings so far

I attempted to edit build.gradle, gradle.properties, and plugin-descriptor.properties to reflect my current version of Elasticsearch (5.0.2) and build the plugin myself using gradle plugin.

When I do this, there are many instances of Elasticsearch-specific classes not being found. In particular, these statements seem to cause problems

import org.elasticsearch.common.logging.ESLogger;
import org.elasticsearch.index.mapper.MappedFieldType.Names;
import static org.elasticsearch.index.mapper.MapperBuilders.binaryField;
import static org.elasticsearch.index.mapper.MapperBuilders.stringField;
import org.elasticsearch.index.query.BoostableQueryBuilder;
import org.elasticsearch.index.query.QueryParsingException;

Note: these statements are all in different files and do not appear one right after another in the actual code.

These seem to be actual issues stemming from the differences between 2.4 and 5.0. I've confirmed that MapperBuilders is a file that existed in 2.4 but was removed in 5.0.

kiwionly commented 7 years ago

5.0 ia not compatible with 2.x, basically it need to completely rewrite, it is difficulty to just do it because lack of plugin documentation.

Yes , I ams plan to support 5.0, some how I am quite busy recently, no time to work on this (and also due to my poor knowledge).

On Dec 3, 2016 12:17 AM, "Nick Stanisha" notifications@github.com wrote:

Elasticsearch 5.0 https://www.elastic.co/v5 has been released and this plugin has not yet been updated to support the new version. Are there plans to support future versions of ES? My findings so far

I attempted to edit build.gradle, gradle.properties, and plugin-descriptor.properties to reflect my current version of Elasticsearch (5.0.2) and build the plugin myself using gradle plugin.

When I do this, there are many instances of Elasticsearch-specific classes not being found. In particular, these statements seem to cause problems

import org.elasticsearch.common.logging.ESLogger;import org.elasticsearch.index.mapper.MappedFieldType.Names;import static org.elasticsearch.index.mapper.MapperBuilders.binaryField;import static org.elasticsearch.index.mapper.MapperBuilders.stringField;import org.elasticsearch.index.query.BoostableQueryBuilder;import org.elasticsearch.index.query.QueryParsingException;

Note: these statements are all in different files and do not appear one right after another in the actual code.

These seem to be actual issues stemming from the differences between 2.4 and 5.0. I've confirmed that MapperBuilders is a file that existed in 2.4 https://github.com/elastic/elasticsearch/blob/2.4/core/src/main/java/org/elasticsearch/index/mapper/MapperBuilders.java but was removed in 5.0 https://github.com/elastic/elasticsearch/tree/5.1/core/src/main/java/org/elasticsearch/index/mapper .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kiwionly/elasticsearch-image/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKqGRdRhBds-Zo4SFMUBoO2ZDSIAhn5ks5rEESKgaJpZM4LCuIG .

negon commented 7 years ago

heres to hoping that you find time to update it :)