kiwitcms / kiwitcms.github.io

kiwitcms.org website
https://kiwitcms.org
11 stars 18 forks source link

Unusual behavior when using video play icon functionality #69

Open zahari opened 5 years ago

zahari commented 5 years ago

Description of problem

On the website video buttons on the bottom row events are not aligned properly. https://imgur.com/a/dArJsgW

Version or commit hash (if applicable)

https://github.com/kiwitcms/kiwitcms.github.io/commit/d1389af4fd58126c958911784edd552e0bbfa61d

Steps to Reproduce

  1. Open http://kiwitcms.org/
  2. Look at DOM component #seen-at
  3. Observe unusual behavior while playing the videos for each event

Actual results

Expected results

atodorov commented 5 years ago

video play button is normally situated on in the center of the image

Two comments on this: 1) Who says the center position is "normal" ? Which is the authoritative body on this design? You need some data to back up this claim, otherwise it is only your personal opinion on how things should look like.

2) putting the play button in the center will hide some of the images. How much and to what extent we don't know before we have tried it and seen how it will look like. May turn out to be not that bad, may turn out to be worse.

The Esc and X functionality for closing the window is indeed something that is missing and is not related to the play button positioning.