kiwiupover / ember-cli-spinjs

Spin.js wrapper for ember.js
http://ember-cli-spinjs.surge.sh
MIT License
35 stars 15 forks source link

An in-range update of eslint-plugin-ember is breaking the build 🚨 #220

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency eslint-plugin-ember was updated from 6.7.0 to 6.7.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-ember is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - βœ… **ci/circleci: checkout_code:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/kiwiupover/ember-cli-spinjs/2304?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: install_dependencies:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/kiwiupover/ember-cli-spinjs/2305?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

Release Notes for v6.7.1

πŸ› Bug Fix

  • #440 Add missing rules classic-decorator-hooks and classic-decorator-no-classic-methods to index.js (@bmish)

Committers: 1

Commits

The new version differs by 8 commits.

  • 4d48fdd v6.7.1
  • 9ee539b Update CHANGELOG
  • a6f1e97 Merge pull request #444 from ember-cli/dependabot/npm_and_yarn/eslint-config-prettier-6.0.0
  • cae5861 Merge pull request #440 from bmish/missing-classic-decorator-rules
  • 35b567c build(deps-dev): bump eslint-config-prettier from 5.1.0 to 6.0.0
  • e5f9e68 build(deps-dev): bump eslint-config-prettier from 5.0.0 to 5.1.0 (#442)
  • 0221e1e build(deps-dev): bump eslint-plugin-import from 2.17.3 to 2.18.0 (#441)
  • 01bb69a fix: add missing rules classic-decorator-hooks and classic-decorator-no-classic-methods to index.js

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 6.7.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v6.8.2

πŸ› Bug Fix

  • #461 Add null check in new-module-imports rule (again) (@bmish)

Committers: 1

Commits

The new version differs by 39 commits.

  • fa498dd v6.8.2
  • 267523b Update CHANGELOG
  • ee5a34c Merge pull request #461 from bmish/new-module-imports-fix-loop
  • 6ff65ba Add null check in new-module-imports rule (again)
  • 42c375c v6.8.1
  • 9fc6f45 Update CHANGELOG
  • 8403de5 Merge pull request #460 from dcyriller/fix-new-module-util
  • 6a7d769 utils: Guard against empty body
  • a6e3293 Add a failing test
  • 139b452 v6.8.0
  • 806214b Update CHANGELOG
  • 8d22073 Merge pull request #450 from dcyriller/data-rfc395
  • 215cf90 Split utils functions is smaller ones
  • 07a04a9 Remove useless run
  • 045e9c0 Rename rule to use-ember-data-rfc-395-imports

There are 39 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v6.9.0

πŸš€ Enhancement

  • #458 Add new rule require-computed-property-dependencies (@bmish)

πŸ› Bug Fix

  • #463 Fix false positives for import statements with use-ember-data-rfc-395-imports rule (@fusion2004)

🏠 Internal

  • #465 Add tests that rules are setup correctly (not missing tests, docs, exports, etc) (@bmish)
  • #466 Fix eslint 6 rule test parser error (@bmish)

Committers: 2

Commits

The new version differs by 50 commits.

  • 344ef33 v6.9.0
  • 85a0c5f Update CHANGELOG
  • ef7d2e0 Merge pull request #458 from bmish/require-computed-property-dependencies
  • 2b7521d build(deps): [security] bump stringstream from 0.0.5 to 0.0.6 (#467)
  • 6b2b668 Merge pull request #465 from bmish/test-rule-setup
  • 69e7a4a Merge pull request #466 from bmish/eslint-6-parser-test-error
  • d0bacc0 feat: add new rule require-computed-property-dependencies
  • 5ca8fc3 test: fix eslint 6 rule test parser error
  • 0a6963c test: add tests that rules are setup correctly (not missing tests, docs, exports, etc)
  • 1da0fb4 Merge pull request #463 from fusion2004/fix-ember-data-rfc395-rule
  • 41de083 Change use-ember-data-rfc-395-imports to not match against imports from libraries whose names start with 'ember-data'
  • fa498dd v6.8.2
  • 267523b Update CHANGELOG
  • ee5a34c Merge pull request #461 from bmish/new-module-imports-fix-loop
  • 6ff65ba Add null check in new-module-imports rule (again)

There are 50 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v6.9.1

πŸ› Bug Fix

  • #472 Improve handling of nested keys inside braces for require-computed-property-dependencies rule (@bmish)
  • #471 Improve detection of missing dependencies in require-computed-property-dependencies rule (@bmish)

Committers: 1

Commits

The new version differs by 57 commits.

  • db22a42 v6.9.1
  • 007527f Update CHANGELOG
  • 2170ff2 Merge pull request #472 from bmish/require-computed-property-dependencies-nested-braces
  • 2502840 fix: improve handling of nested keys inside braces for require-computed-property-dependencies rule
  • 5844540 Merge pull request #471 from bmish/require-computed-property-dependencies-tweaks
  • 7912aff fix: improve detection of missing dependencies in require-computed-property-dependencies rule
  • 2b6ce75 build(deps): bump ember-rfc176-data from 0.3.9 to 0.3.10 (#469)
  • 344ef33 v6.9.0
  • 85a0c5f Update CHANGELOG
  • ef7d2e0 Merge pull request #458 from bmish/require-computed-property-dependencies
  • 2b7521d build(deps): [security] bump stringstream from 0.0.5 to 0.0.6 (#467)
  • 6b2b668 Merge pull request #465 from bmish/test-rule-setup
  • 69e7a4a Merge pull request #466 from bmish/eslint-6-parser-test-error
  • d0bacc0 feat: add new rule require-computed-property-dependencies
  • 5ca8fc3 test: fix eslint 6 rule test parser error

There are 57 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v6.10.0

πŸš€ Enhancement

  • #473 Add new no-incorrect-calls-with-inline-anonymous-functions rule (@raycohen)

πŸ› Bug Fix

  • #476 Add allowDynamicKeys option (default true) to require-computed-property-dependencies rule (@bmish)

Committers: 2

Commits

The new version differs by 64 commits.

  • 590cf98 v6.10.0
  • 46502cf Update CHANGELOG
  • 2e0469e Merge pull request #473 from raycohen/no-inline-anonymous-functions-to-schedule-once
  • 434b44d Merge pull request #476 from bmish/require-computed-property-dependencies-allowDynamicKeys-option
  • 5a9a0fe Add new no-incorrect-calls-with-inline-anonymous-functions rule
  • 55537f6 build(deps): bump ember-rfc176-data from 0.3.10 to 0.3.11 (#478)
  • 2733279 fix: add allowDynamicKeys option (default true) to require-computed-property-dependencies rule
  • db22a42 v6.9.1
  • 007527f Update CHANGELOG
  • 2170ff2 Merge pull request #472 from bmish/require-computed-property-dependencies-nested-braces
  • 2502840 fix: improve handling of nested keys inside braces for require-computed-property-dependencies rule
  • 5844540 Merge pull request #471 from bmish/require-computed-property-dependencies-tweaks
  • 7912aff fix: improve detection of missing dependencies in require-computed-property-dependencies rule
  • 2b6ce75 build(deps): bump ember-rfc176-data from 0.3.9 to 0.3.10 (#469)
  • 344ef33 v6.9.0

There are 64 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v6.10.1

πŸ› Bug Fix

  • #488 Update require-computed-property-dependencies rule to support eslint 3 and 4 (@bmish)

πŸ“ Documentation

  • #489 Document eslint 4 as the minimum supported version (@bmish)

🏠 Internal

  • #482 Start testing plugin under Node 12 (@bmish)

Committers: 1

Commits

The new version differs by 15 commits.

  • 362b42b v6.10.1
  • 60e1dce Update CHANGELOG
  • 84b2469 Merge pull request #489 from bmish/eslint-4-minimum-version
  • a2bf4bd Revert "chore(dev-deps): upgrade to eslint 5.16.0"
  • c8e6d0d docs: Document eslint 4 as the minimum supported version
  • 8eb61cf Merge pull request #488 from bmish/require-computed-property-dependencies-eslint4-fix
  • f317d94 fix: update require-computed-property-dependencies rule to work in eslint 3 and eslint 4
  • f2b96cb Merge pull request #483 from bmish/script-lint-js
  • 6a87c5e Merge pull request #482 from bmish/test-node-12
  • bcef6ea Add yarn lint:js script which is called by yarn lint.
  • 29c84ff test: start testing plugin under Node 12
  • 2a5f4d3 Merge pull request #480 from bmish/bmishkin/readme-remove-node-6
  • 40a5bed build(deps-dev): bump jest from 24.8.0 to 24.9.0 (#474)
  • 498b704 build(deps-dev): bump eslint-config-prettier from 6.0.0 to 6.1.0 (#481)
  • 2bc6ca9 docs: update supported Node versions mentioned in README

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.6.0

πŸš€ Enhancement

Committers: 1

Commits

The new version differs by 241 commits.

  • 38ff4a4 v7.6.0
  • ada40e5 Update CHANGELOG
  • 1c18fd9 Merge pull request #594 from steventsao/master
  • 6fee2e4 Move spec link
  • 916cc05 Update description
  • bb54e16 Simplify error message and escape pipe
  • da398e4 Fix unnecessary backslashes
  • cc80588 Change import statement
  • f9d1a56 Rewrite rule doc
  • 62de848 Add one line after require statements
  • a587251 Rewrite reason for nullish coalescing
  • 0eabaa5 Update allowed example
  • 1009f17 Recommend native getter for no-get-with-default
  • 341df7c no-get-with-default
  • 7fff62e build(deps-dev): bump eslint-config-prettier from 6.5.0 to 6.6.0 (#596)

There are 241 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.7.0

πŸš€ Enhancement

  • #592 Update no-classic-classes rule to catch classic Ember Data model classes (@patocallaghan)

πŸ› Bug Fix

  • #610 Fix invalid no-get rule autofix caused by invalid JS variable name (@bmish)
  • #607 Fix spread property bug in require-super-in-init rule (@bmish)
  • #600 Add missing schema validation for options on many rules (@bmish)

🏠 Internal

  • #611 Add many missing tests for lines without test coverage (@bmish)

Committers: 2

Commits

The new version differs by 269 commits.

  • ab24549 v7.7.0
  • 865b7a8 Update CHANGELOG
  • 188e7ca Merge pull request #610 from bmish/no-get-autofixer-fix-invalid-var-name
  • 4701730 Merge pull request #611 from bmish/add-many-missing-tests
  • 0228362 test: raise minimum test coverage thresholds
  • 7771217 test: add many missing tests for uncovered lines identified by istanbul
  • 66e54cf Merge pull request #613 from bmish/no-restricted-resolver-tests-simplify-tests
  • cb70d06 test: simplify tests for no-restricted-resolver-tests rule by using global parserOptions
  • d9f6b41 build(deps-dev): bump eslint from 6.7.0 to 6.7.1 (#612)
  • 9e7fc07 fix: invalid no-get rule autofix caused by invalid JS variable name
  • d5fa7bb Merge pull request #607 from bmish/require-super-in-init-fix-spread-bug
  • 3a1f75f build(deps-dev): bump eslint from 6.6.0 to 6.7.0 (#608)
  • 72438bb fix: spread property bug in require-super-in-init rule
  • 0798a49 Merge pull request #605 from bmish/move-import-utils
  • 11cb0a5 refactor: move import utils to separate file

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.7.1

πŸ› Bug Fix

  • #615 Fix issue causing assert to fire in getSourceModuleName util function (@patocallaghan)

Committers: 1

Commits

The new version differs by 274 commits.

  • bf79053 v7.7.1
  • 3bc96ef Update CHANGELOG
  • ca0389f Merge pull request #615 from patocallaghan/patoc/fix-assertion-issue
  • 3c4ba73 test: add getSourceModuleName util function test with CallExpression
  • 5169468 Fix issue with assertion firing on getSourceModuleName
  • ab24549 v7.7.0
  • 865b7a8 Update CHANGELOG
  • 188e7ca Merge pull request #610 from bmish/no-get-autofixer-fix-invalid-var-name
  • 4701730 Merge pull request #611 from bmish/add-many-missing-tests
  • 0228362 test: raise minimum test coverage thresholds
  • 7771217 test: add many missing tests for uncovered lines identified by istanbul
  • 66e54cf Merge pull request #613 from bmish/no-restricted-resolver-tests-simplify-tests
  • cb70d06 test: simplify tests for no-restricted-resolver-tests rule by using global parserOptions
  • d9f6b41 build(deps-dev): bump eslint from 6.7.0 to 6.7.1 (#612)
  • 9e7fc07 fix: invalid no-get rule autofix caused by invalid JS variable name

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.7.2

πŸ› Bug Fix

  • #621 Fix false positive with ignoreNonThisExpressions option in use-ember-get-and-set rule (@Exelord)

πŸ“ Documentation

  • #620 Use consistent prefixes for rule descriptions (@bmish)

🏠 Internal

  • #625 Add eslint-plugin-jest internally and enable rules (@bmish)
  • #624 Add eslint-plugin-unicorn internally and enable recommended rules (@bmish)

Committers: 2

Commits

The new version differs by 291 commits.

  • 1805883 v7.7.2
  • 39539bc Update CHANGELOG
  • 9943b7e Merge pull request #625 from bmish/eslint-plugin-jest
  • cb4824d chore(lint): add eslint-plugin-jest internally and enable rules
  • dc149b5 Merge pull request #624 from bmish/eslint-plugin-unicorn
  • 9a6a4be chore(lint): add eslint-plugin-unicorn internally and autofix recommended rules
  • c93198c build(deps-dev): bump eslint-plugin-import from 2.18.2 to 2.19.1 (#623)
  • e2c5235 build(deps): bump snake-case from 3.0.1 to 3.0.2 (#622)
  • 4c6aedd Merge pull request #621 from Exelord/fix/ignore-this-expressions
  • ed6301a chore: fix lint violation
  • b3d07e1 Merge pull request #618 from ember-cli/dependabot/npm_and_yarn/snake-case-3.0.1
  • 289f64b chore: update import for compatibility with snake-case v3
  • eb72f84 Merge pull request #620 from bmish/docs-rule-desc
  • 7d318d0 Fix ignoreNonThisExpressions
  • 5bcd237 docs: use consistent prefixes for rule descriptions

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.8.0

πŸš€ Enhancement

  • #661 Add new rule no-controllers (@bmish)
  • #665 Update order-in-* rules to support custom ordering of properties (@cdtinney)
  • #639 Update no-observers rule to catch addObserver and observer imports (@kategengler)

πŸ› Bug Fix

  • #670 Update order-in-* rules to consider template literals as properties (@cdtinney)
  • #664 Update no-classic-components rule to only disallow the specific component import (@bmish)
  • #640 Update no-computed-properties-in-native-classes rule to catch aliasing of computed import (@kategengler)

πŸ“ Documentation

  • #663 Update rule docs to use consistent headers and fix markdownlint violations (@bmish)
  • #655 Update no-new-mixins rule documentation (@efx)
  • #648 Fix various spelling mistakes (@bmish)
  • #647 Fix typo in no-classic-components rule documentation (@rwwagner90)
  • #626 Simplify and clarify rules and configuration sections in README (@bmish)

🏠 Internal

  • #643 Add missing test case output assertions (@bmish)

Committers: 5

Commits

The new version differs by 352 commits.

  • e8ccb5d v7.8.0
  • c292863 Update CHANGELOG
  • 81133b9 test: fix failing test case and lint violations from recent merge
  • 920ae63 docs: fix new markdownlint violations in order-in-* rule docs
  • 3b411f9 Merge pull request #665 from cdtinney/custom-prop-ordering
  • d7ade4b Merge pull request #670 from cdtinney/fix-order-in-rules-template-literals
  • 412daa6 Merge pull request #666 from bmish/markdownlint-cli
  • bb15ca8 test: add markdownlint-cli to linting / CI scripts
  • f37b280 fix: consider TemplateLiteral as property in order-in-* rules
  • 3f50a88 fix rebase conflicts
  • 4896ef3 Merge pull request #661 from bmish/no-controllers
  • ffb917b Merge pull request #664 from bmish/no-classic-components-only-default-import
  • a789026 Adds docs around custom ordering to order-in-*.mds
  • 043dabd Adds tests around custom order-in-* prop ordering
  • cd64022 Updates order-in-* to allow for custom prop order

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.8.1

πŸ› Bug Fix

  • #674 Update require-computed-property-dependencies rule to handle basic string concatenation in dependent keys (@bmish)

πŸ“ Documentation

  • #669 Add "Help Wanted" section to documentation for rules that are missing native JavaScript class support (@bmish)

Committers: 1

Commits

The new version differs by 358 commits.

  • a6a777b v7.8.1
  • 465fb5a Update CHANGELOG
  • 5f6d3c4 Merge pull request #674 from bmish/require-computed-property-dependencies-two-part-string
  • 70f4941 Merge pull request #669 from bmish/docs-syntax-support
  • 5e1d604 fix: update require-computed-property-dependencies rule to handle basic string concatenation in dependent keys
  • 4f0a7e5 docs: add 'Help Wanted' section to docs for rules that are missing native JS class support
  • e8ccb5d v7.8.0
  • c292863 Update CHANGELOG
  • 81133b9 test: fix failing test case and lint violations from recent merge
  • 920ae63 docs: fix new markdownlint violations in order-in-* rule docs
  • 3b411f9 Merge pull request #665 from cdtinney/custom-prop-ordering
  • d7ade4b Merge pull request #670 from cdtinney/fix-order-in-rules-template-literals
  • 412daa6 Merge pull request #666 from bmish/markdownlint-cli
  • bb15ca8 test: add markdownlint-cli to linting / CI scripts
  • f37b280 fix: consider TemplateLiteral as property in order-in-* rules

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.9.0

πŸš€ Enhancement

  • #595 Add new rule no-component-lifecycle-hooks (included in octane config) (@jbandura)
  • #681 Add new rule no-legacy-test-waiters (@scalvert)

πŸ“ Documentation

  • #688 Lint code samples with eslint-plugin-markdown (@bmish)

Committers: 3

Commits

The new version differs by 399 commits.

  • af84382 v7.9.0
  • 084461f Update CHANGELOG
  • a5203e4 Merge pull request #595 from jbandura/rule-no-component-lifecycle-hooks
  • 88ae1d5 docs: cleanup headers in doc for no-component-lifecycle-hooks
  • 1e6e1a0 Appease linter yet again
  • 429f5fd Fix code example to satisfy linter
  • 10588c5 Fix edge case for nested ClassDeclaration, code cleanup
  • 266c20f Move default exports in docs to separate code snippets
  • b58b22c Fix issue & add test case for multiple CallExpression case
  • b3f122a Add tests to isGlimmerComponent and use isComponentLifecycleHook util
  • 20114b4 Undo yarn.lock change
  • 84c79b9 Fix lint issues
  • 9dec68f Merge pull request #688 from bmish/eslint-plugin-markdown
  • fbbe3a8 Apply review suggestions
  • e6e727d docs: lint code samples with eslint-plugin-markdown

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.10.0

πŸš€ Enhancement

Committers: 1

Commits

The new version differs by 406 commits.

  • 7a0c8f8 v7.10.0
  • f589fe3 Update CHANGELOG
  • 1470b8f Merge pull request #694 from nlfurniss/no-private-routing-service
  • 66aae10 Merge pull request #691 from nlfurniss/no-mixins-rule
  • d56f2d9 Add new rule no-private-routing-service
  • e1dff32 build(deps-dev): bump eslint-plugin-jest from 23.8.0 to 23.8.2 (#693)
  • ccfa44d Add rule to disallow mixins
  • af84382 v7.9.0
  • 084461f Update CHANGELOG
  • a5203e4 Merge pull request #595 from jbandura/rule-no-component-lifecycle-hooks
  • 88ae1d5 docs: cleanup headers in doc for no-component-lifecycle-hooks
  • 1e6e1a0 Appease linter yet again
  • 429f5fd Fix code example to satisfy linter
  • 10588c5 Fix edge case for nested ClassDeclaration, code cleanup
  • 266c20f Move default exports in docs to separate code snippets

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.10.1

πŸ› Bug Fix

  • #697 Handle service injections with no arguments in no-private-routing-service rule (@nlfurniss)

Committers: 1

Commits

The new version differs by 413 commits.

  • 53a62e2 v7.10.1
  • c5b5e31 Update CHANGELOG
  • 1517d06 Merge pull request #698 from bmish/rule-error-tweaks
  • aeeacdb fix: tweak error message for no-observers rule
  • 251fcbf fix: tweak error message for no-attrs-in-components rule
  • e114981 Merge pull request #697 from nlfurniss/private-router-fix
  • c9f061f fix bug in no-private-routing-service when service CallExpression has no argument
  • 7a0c8f8 v7.10.0
  • f589fe3 Update CHANGELOG
  • 1470b8f Merge pull request #694 from nlfurniss/no-private-routing-service
  • 66aae10 Merge pull request #691 from nlfurniss/no-mixins-rule
  • d56f2d9 Add new rule no-private-routing-service
  • e1dff32 build(deps-dev): bump eslint-plugin-jest from 23.8.0 to 23.8.2 (#693)
  • ccfa44d Add rule to disallow mixins
  • af84382 v7.9.0

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v7.11.0

πŸš€ Enhancement

  • #695 Add new rule no-incorrect-computed-macros (@bmish)
  • #709 Add new rule no-invalid-dependent-keys (@TheMBTH)
  • #718 Add new rule no-replace-test-comments (@jaydgruber)
  • #705 Support TypeScript files when checking if rules are running on Ember module or test files (@bmish)

πŸ› Bug Fix

  • #719 Validate imports before reporting violations in no-invalid-debug-function-arguments rule (@bmish)

πŸ“ Documentation

  • #716 Revamp the guide for contributing a new rule (@bmish)
  • #715 Mention if a rule is auto-fixable in its documentation (@bmish)
  • #713 Add tests to ensure each rule documentation file has the right title and an examples section (@bmish)
  • #711 Improve contribution guide for adding new rules (@TheMBTH)

🏠 Internal

  • #720 Add tests to ensure some computed property rules handle the @computed decorator (@bmish)

Committers: 3

Commits

The new version differs by 443 commits.

  • f2e1feb v7.11.0
  • 9018fba Update CHANGELOG
  • acb2d67 Merge pull request #720 from bmish/computed-decorators
  • a8d5237 tes: add tests to ensure some computed property rules handle the computed decorator
  • 4791818 Merge pull request #719 from bmish/no-invalid-debug-function-arguments-check-imports
  • e7ac741 fix: add import checking to no-invalid-debug-function-arguments
  • 9779724 Merge pull request #695 from bmish/no-incorrect-computed-macros
  • 78d8ec4 Merge pull request #709 from TheMBTH/ISSUE-708
  • d177089 Apply suggestions from code review
- [`2a5ea22`](https://github.com/ember-cli/eslint-plugin-ember/commit/2a5ea224029cb86f1282beca44f605cb9421dc80) Apply suggestions from code review - [`4866534`](https://github.com/ember-cli/eslint-plugin-ember/commit/48665341c1cbfbd6ef418f9e2910e08cba413eeb) Add new rule `no-replace-test-comments` (#718) - [`8e5e632`](https://github.com/ember-cli/eslint-plugin-ember/commit/8e5e6326049e5881fb726bec19e039fcd2440d84) feat: add new rule no-incorrect-computed-macros - [`40c12a2`](https://github.com/ember-cli/eslint-plugin-ember/commit/40c12a229b5f54836cefba277e26536230f9b05f) ISSUE #708 - Add rule "no-invalid-dependent-keys" to require that dependent keys used for computed properties to be valid. - [`2029651`](https://github.com/ember-cli/eslint-plugin-ember/commit/2029651e09134f4662267c0c75f8e5f7f1651c5f) docs: fix parentheses - [`0d88793`](https://github.com/ember-cli/eslint-plugin-ember/commit/0d887938824496bcde6bf5d2ab4efe32b141e471) Merge pull request #716 from bmish/docs-new-rule-rewrite

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.11.1

πŸ› Bug Fix

  • #728 Allow brace expansion with and, or macros in no-incorrect-computed-macros rule (@bmish)

πŸ“ Documentation

  • #724 Recategorize rules in README (@bmish)
  • #723 Sort rule categories alphabetically in README (@bmish)

Committers: 1

Commits

The new version differs by 14 commits.

  • ccd91d0 v7.11.1
  • 7febf8e Update CHANGELOG
  • 40018aa Merge pull request #728 from bmish/fix-no-incorrect-computed-macros-brace-expansion
  • 46e2d14 fix: allow brace expansion with and, or in no-incorrect-computed-macros rule
  • a30c342 Merge pull request #724 from bmish/categories-reorganize
  • c73d0f6 build(deps-dev): bump eslint-config-prettier from 6.10.0 to 6.10.1 (#726)
  • 18dcc1a docs: recategorize rules into new groups
  • 1a1d7a3 docs: use case-insensitive sorting of rule categories in README
  • 0f72605 Merge pull request #723 from bmish/docs-sort-categories
  • bde15c0 docs: sort README rule categories alphabetically
  • 237c8fc Merge pull request #722 from bmish/rule-desc-tweaks
  • 17634d3 docs: tweak some rule descriptions for clarity
  • 294f7d0 Merge pull request #721 from bmish/docs-readme-new-rule-eslint-link
  • dfa0d06 docs: add link to eslint 'working with rules' doc in README

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.12.0

πŸš€ Enhancement

  • #738 Use sets instead of arrays for better performance (@bmish)
  • #702 Add new rule no-invalid-test-waiters (@scalvert)

πŸ“ Documentation

  • #737 Mention tracked properties as a fix for classic-decorator-no-classic-methods (@bmish)

🏠 Internal

Committers: 2

Commits

The new version differs by 33 commits.

  • fde159f v7.12.0
  • a6e4dda Update CHANGELOG
  • e7b972f Merge pull request #737 from bmish/classic-decorator-no-classic-methods-tracked-properties
  • 00dc010 Merge pull request #739 from bmish/no-invalid-test-waiters-fix-crashes
  • d5c95c7 Merge pull request #740 from ember-cli/bmish-docs-no-invalid-test-waiters-examples
  • 3c443e5 Improve examples for no-invalid-test-waiters rule
  • e987200 Update docs/rules/classic-decorator-no-classic-methods.md
  • ac32425 fix: fix crashes in no-invalid-test-waiters rule
  • ae0e187 Merge pull request #738 from bmish/set-not-array
  • c6f1ea2 refactor: use sets instead of arrays for better performance
  • 712a9ec Merge pull request #702 from scalvert/use-waiters-in-module-scope
  • ae56cc7 docs: mention tracked properties as a fix for classic-decorator-no-classic-methods
  • 7f1059f build(deps-dev): bump jest from 24.9.0 to 25.2.3 (#735)
  • f377dac Merge pull request #732 from bmish/test-node-13
  • 5969015 test: begin testing under Node 13

There are 33 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v7.13.0

πŸš€ Enhancement

  • #742 Detect invalid position of @each or [] in no-invalid-dependent-keys rule (@bmish)

🏠 Internal

  • #741 Switch from Travis to GitHub Actions for CI (@bmish)

Committers: 1

Commits

The new version differs by 39 commits.

  • 17f8c8d v7.13.0
  • d191ac1 Update CHANGELOG
  • fb055e9 Merge pull request #742 from bmish/no-invalid-dependent-keys-invalid-at-each-brackets
  • 6de1c50 feat: detect invalid position of @each or [] in no-invalid-dependent-keys rule
  • 61db683 Merge pull request #741 from ember-cli/bmish-github-actions
  • 248686b test: switch from Travis to GitHub Actions for CI
  • fde159f v7.12.0
  • a6e4dda Update CHANGELOG
  • e7b972f Merge pull request #737 from bmish/classic-decorator-no-classic-methods-tracked-properties
  • 00dc010 Merge pull request #739 from bmish/no-invalid-test-waiters-fix-crashes
  • d5c95c7 Merge pull request #740 from ember-cli/bmish-docs-no-invalid-test-waiters-examples
  • 3c443e5 Improve examples for no-invalid-test-waiters rule
  • e987200 Update docs/rules/classic-decorator-no-classic-methods.md
  • ac32425 fix: fix crashes in no-invalid-test-waiters rule
  • ae0e187 Merge pull request #738 from bmish/set-not-array

There are 39 commits in total.

See the full diff