kiwix / container-images

10 stars 4 forks source link

Release permalink for libkiwix_xcframework.tar.gz don't work #256

Closed kelson42 closed 11 months ago

kelson42 commented 11 months ago

Releases:

$ curl -I https://download.kiwix.org/release/libkiwix/libkiwix_xcframework.tar.gz
HTTP/2 404 
date: Sun, 10 Dec 2023 11:44:43 GMT
content-type: text/html; charset=iso-8859-1
strict-transport-security: max-age=15724800; includeSubDomains

But it seems to work for nightly

$ curl -I https://download.kiwix.org/nightly/libkiwix_xcframework.tar.gz
HTTP/2 301 
date: Sun, 10 Dec 2023 11:48:13 GMT
content-type: text/html; charset=iso-8859-1
location: https://download.kiwix.org/nightly/2023-12-10/libkiwix_xcframework-2023-12-10.tar.gz
cache-control: no-store, no-cache, must-revalidate
strict-transport-security: max-age=15724800; includeSubDomains

... not sure if permalink URL should be different or if something else is broken.

rgaudin commented 11 months ago

You seem lost in repos ; that would be for k8s 😉 Fixed in https://github.com/kiwix/k8s/commit/fed9ef619b541fc6fa27fd4e95e4082f1cac41ec

We intentionally create permalinks for releases based on known/expected patterns while nightlies exposes everything by looking for the date.

Maybe we should reconsider given we frequently add new files

kelson42 commented 11 months ago

I don't know if current approach is optimal... but indeed you might have to change soon again with new "swift package".

rgaudin commented 11 months ago

The swift package won't be a file on download.kiwix.org 😉