Closed MohitMaliFtechiz closed 2 years ago
@MohitMaliFtechiz Codefactor should be green. IMO there is far too many things in this PR which should not be there. Please commit only your code, all the rest should be built dynamically or downloaded during the compilation.
hi @mgautierfr , @kelson42
Now i have clean up the code , and written the step on README file , header files and .so will be part during compilation and need to placed in place holder then running build command will generate .aar file.
@MohitMaliFtechiz Do all the headers are generated manually?! Does not look like, they should not be here IMO.
@MohitMaliFtechiz Do all the headers are generated manually?! Does not look like, they should not be here IMO.
During CI/CD , after kiwix-build we can write shell script which will copy the header from sources and copied on directory and build the .aar.
This is important because otherwise we need to maintains headers files from several repo.
@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?
@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?
I believe you are talking about the headers file which i generated using javah. Yes we can remove those headers file and everytime generated it from java classes.
@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?
I believe you are talking about the headers file which i generated using javah. Yes we can remove those headers file and everytime generated it from java classes.
Yes I'm. These files should be removed from the source code and generated at compilation time. I can only repeat what I have written above: no automatically generated file should be part of the source code. All of them should be generated at compilation time.
I would prefer to have only one .gitignore
I would prefer to have only one .gitignore
hi @kelson42 I have include the several .gitignore to push the empty folder otherwise it not adding empty folder.
I would prefer to have only one .gitignore
hi @kelson42 I have include the several .gitignore to push the empty folder otherwise it not adding empty folder.
It should work, git
supports empty directories.
Hi @kelson42 ,
I am closing this PR since i have rebase this branch on https://github.com/kiwix/java-libkiwix/pull/20, that pull contain all this PR changes.
Here too, please never commit built/binary files... like .jar.