kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

11.0.0 building #12

Closed MohitMaliFtechiz closed 2 years ago

kelson42 commented 2 years ago

Here too, please never commit built/binary files... like .jar.

kelson42 commented 2 years ago

@MohitMaliFtechiz Codefactor should be green. IMO there is far too many things in this PR which should not be there. Please commit only your code, all the rest should be built dynamically or downloaded during the compilation.

MohitMaliFtechiz commented 2 years ago

hi @mgautierfr , @kelson42

Now i have clean up the code , and written the step on README file , header files and .so will be part during compilation and need to placed in place holder then running build command will generate .aar file.

kelson42 commented 2 years ago

@MohitMaliFtechiz Do all the headers are generated manually?! Does not look like, they should not be here IMO.

MohitMaliFtechiz commented 2 years ago

@MohitMaliFtechiz Do all the headers are generated manually?! Does not look like, they should not be here IMO.

During CI/CD , after kiwix-build we can write shell script which will copy the header from sources and copied on directory and build the .aar.

This is important because otherwise we need to maintains headers files from several repo.

kelson42 commented 2 years ago

@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?

MohitMaliFtechiz commented 2 years ago

@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?

I believe you are talking about the headers file which i generated using javah. Yes we can remove those headers file and everytime generated it from java classes.

kelson42 commented 2 years ago

@MohitMaliFtechiz These headers have not been written by hand. Do I'm correct?

I believe you are talking about the headers file which i generated using javah. Yes we can remove those headers file and everytime generated it from java classes.

Yes I'm. These files should be removed from the source code and generated at compilation time. I can only repeat what I have written above: no automatically generated file should be part of the source code. All of them should be generated at compilation time.

kelson42 commented 2 years ago

I would prefer to have only one .gitignore

MohitMaliFtechiz commented 2 years ago

I would prefer to have only one .gitignore

hi @kelson42 I have include the several .gitignore to push the empty folder otherwise it not adding empty folder.

kelson42 commented 2 years ago

I would prefer to have only one .gitignore

hi @kelson42 I have include the several .gitignore to push the empty folder otherwise it not adding empty folder.

It should work, git supports empty directories.

MohitMaliFtechiz commented 2 years ago

Hi @kelson42 ,

I am closing this PR since i have rebase this branch on https://github.com/kiwix/java-libkiwix/pull/20, that pull contain all this PR changes.