kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Building wrapper outside the libikiwix ,Refactoring wrapper to support libkiwix12 , CI support , CD deployment to maven. #20

Closed MohitMaliFtechiz closed 1 year ago

MohitMaliFtechiz commented 2 years ago

This PR contain the following. a) Since we have removed the Java wrapper on 11.0.0 , so first building 11.0.0 with external java wrapper with building libzim and libkiwix so files. b) on libkiwix 12, we have removed the Reader.cpp and Searcher.cpp so that requried lots of refracting on java wrapper side so that is being include. c) Maven publishing gradle task to publish automatically .

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@215237d). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ======================================= Coverage ? 40.00% Complexity ? 10 ======================================= Files ? 13 Lines ? 60 Branches ? 3 ======================================= Hits ? 24 Misses ? 33 Partials ? 3 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rgaudin commented 1 year ago

@MohitMaliFtechiz I will add redirects to nightlies so you don't have to find/guess date. I'll post back here once it's live.

MohitMaliFtechiz commented 1 year ago

@MohitMaliFtechiz I will add redirects to nightlies so you don't have to find/guess date. I'll post back here once it's live.

Ok @rgaudin

rgaudin commented 1 year ago

@MohitMaliFtechiz @MohitMaliDeveloper it is now live:

Should work for all your URLs. Ping me if not.

MohitMaliFtechiz commented 1 year ago

hi @rgaudin ,

We need dedicated redirect url for every android architecture for both libzim and libkiwix and also for Linux architecture as well so we need 10 urls. a) Libzim :- arm , arm64-v8a, x86 , x86_64 , Linux b) Libkiwix:- arm , arm64-v8a, x86 , x86_64 , Linux

rgaudin commented 1 year ago

I don't understand. This is what we currently have:

/nightly/libzim_macos-x86_64.tar.gz
/nightly/libzim_linux-x86_64.tar.gz
/nightly/libzim_android-arm.tar.gz
/nightly/libzim_android-arm64.tar.gz
/nightly/libzim_android-x86.tar.gz
/nightly/libzim_wasm-emscripten.tar.gz
/nightly/libzim_android-x86_64.tar.gz
/nightly/libkiwix_android-arm.tar.gz
/nightly/libkiwix_macos-x86_64.tar.gz
/nightly/libkiwix_android-x86.tar.gz
/nightly/libkiwix_android-x86_64.tar.gz
/nightly/libkiwix_linux-x86_64.tar.gz
/nightly/libkiwix_android-arm64.tar.gz
MohitMaliFtechiz commented 1 year ago

I don't understand. This is what we currently have:

/nightly/libzim_macos-x86_64.tar.gz
/nightly/libzim_linux-x86_64.tar.gz
/nightly/libzim_android-arm.tar.gz
/nightly/libzim_android-arm64.tar.gz
/nightly/libzim_android-x86.tar.gz
/nightly/libzim_wasm-emscripten.tar.gz
/nightly/libzim_android-x86_64.tar.gz
/nightly/libkiwix_android-arm.tar.gz
/nightly/libkiwix_macos-x86_64.tar.gz
/nightly/libkiwix_android-x86.tar.gz
/nightly/libkiwix_android-x86_64.tar.gz
/nightly/libkiwix_linux-x86_64.tar.gz
/nightly/libkiwix_android-arm64.tar.gz

ok understood this will work.

kelson42 commented 1 year ago

@MohitMaliDeveloper What should we do with this PR

kelson42 commented 1 year ago

@MohitMaliFtechiz @ 2 weeks have passed and still no answer?!

MohitMaliFtechiz commented 1 year ago

@MohitMaliFtechiz @ 2 weeks have passed and still no answer?!

We already have this changes on main branch , i think we can close this PR.