Closed MohitMaliFtechiz closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
main@215237d
). Click here to learn what that means. Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@MohitMaliFtechiz I will add redirects to nightlies so you don't have to find/guess date. I'll post back here once it's live.
@MohitMaliFtechiz I will add redirects to nightlies so you don't have to find/guess date. I'll post back here once it's live.
Ok @rgaudin
@MohitMaliFtechiz @MohitMaliDeveloper it is now live:
Should work for all your URLs. Ping me if not.
hi @rgaudin ,
We need dedicated redirect url for every android architecture for both libzim and libkiwix and also for Linux architecture as well so we need 10 urls. a) Libzim :- arm , arm64-v8a, x86 , x86_64 , Linux b) Libkiwix:- arm , arm64-v8a, x86 , x86_64 , Linux
I don't understand. This is what we currently have:
/nightly/libzim_macos-x86_64.tar.gz
/nightly/libzim_linux-x86_64.tar.gz
/nightly/libzim_android-arm.tar.gz
/nightly/libzim_android-arm64.tar.gz
/nightly/libzim_android-x86.tar.gz
/nightly/libzim_wasm-emscripten.tar.gz
/nightly/libzim_android-x86_64.tar.gz
/nightly/libkiwix_android-arm.tar.gz
/nightly/libkiwix_macos-x86_64.tar.gz
/nightly/libkiwix_android-x86.tar.gz
/nightly/libkiwix_android-x86_64.tar.gz
/nightly/libkiwix_linux-x86_64.tar.gz
/nightly/libkiwix_android-arm64.tar.gz
I don't understand. This is what we currently have:
/nightly/libzim_macos-x86_64.tar.gz /nightly/libzim_linux-x86_64.tar.gz /nightly/libzim_android-arm.tar.gz /nightly/libzim_android-arm64.tar.gz /nightly/libzim_android-x86.tar.gz /nightly/libzim_wasm-emscripten.tar.gz /nightly/libzim_android-x86_64.tar.gz
/nightly/libkiwix_android-arm.tar.gz /nightly/libkiwix_macos-x86_64.tar.gz /nightly/libkiwix_android-x86.tar.gz /nightly/libkiwix_android-x86_64.tar.gz /nightly/libkiwix_linux-x86_64.tar.gz /nightly/libkiwix_android-arm64.tar.gz
ok understood this will work.
@MohitMaliDeveloper What should we do with this PR
@MohitMaliFtechiz @ 2 weeks have passed and still no answer?!
@MohitMaliFtechiz @ 2 weeks have passed and still no answer?!
We already have this changes on main branch , i think we can close this PR.
This PR contain the following. a) Since we have removed the Java wrapper on 11.0.0 , so first building 11.0.0 with external java wrapper with building libzim and libkiwix so files. b) on libkiwix 12, we have removed the Reader.cpp and Searcher.cpp so that requried lots of refracting on java wrapper side so that is being include. c) Maven publishing gradle task to publish automatically .