search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Wrap all cpp code in a try/catch on create corresponding java exception. #36

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

Fix #24

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +6.79 :tada:

Comparison is base (420794e) 85.86% compared to head (ab7bbc1) 92.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ============================================ + Coverage 85.86% 92.65% +6.79% - Complexity 196 212 +16 ============================================ Files 42 43 +1 Lines 290 286 -4 Branches 6 3 -3 ============================================ + Hits 249 265 +16 + Misses 36 18 -18 + Partials 5 3 -2 ``` | [Impacted Files](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix) | Coverage Δ | | |---|---|---| | [lib/src/main/java/org/kiwix/libzim/Archive.java](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix#diff-bGliL3NyYy9tYWluL2phdmEvb3JnL2tpd2l4L2xpYnppbS9BcmNoaXZlLmphdmE=) | `100.00% <ø> (+31.25%)` | :arrow_up: | | [.../java/org/kiwix/libzim/EntryNotFoundException.java](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix#diff-bGliL3NyYy9tYWluL2phdmEvb3JnL2tpd2l4L2xpYnppbS9FbnRyeU5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...ib/src/test/org/kiwix/test/libzim/TestArchive.java](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix#diff-bGliL3NyYy90ZXN0L29yZy9raXdpeC90ZXN0L2xpYnppbS9UZXN0QXJjaGl2ZS5qYXZh) | `95.74% <100.00%> (-2.13%)` | :arrow_down: | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/36/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kelson42 commented 1 year ago

@mgautierfr Does it fix #24?

mgautierfr commented 1 year ago

Yes