Prepare/Release version 1.0.0 of org.kiwix.libkiwix

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin

https://central.sonatype.com/artifact/org.kiwix/libkiwix

GNU General Public License v3.0

3 stars 4 forks source link

Prepare/Release version 1.0.0 of org.kiwix.libkiwix #42

Closed kelson42 closed 1 year ago

kelson42 commented 1 year ago

[x] Secure the CI is green on git main
[x] Update the Changelog
[x] Check if this new release use latest version of libkiwix and libzim
[x] Update version
[x] Close current milestone and create new one incrementaly (a priori a minor version)
[x] Create a tag on git
[x] Secure new version is published on Maven Central
[x] Update the Github release with the Changelog
[ ] Create new empty entry in Changelog (placeholder for future entries)
[ ] Advertise this new version

kelson42 commented 1 year ago

@MohitMaliDeveloper @mgautierfr Why you just have release version 11 and not version 12?!

kelson42 commented 1 year ago

I see that someone has uploaded binaries to https://search.maven.org/artifact/org.kiwix.libkiwix/libkiwix. Who has done this and how?

I wonder as well if it should not be better org.kiwix/libkiwix instead of org.kiwix.libkiwix/libkiwix?

kelson42 commented 1 year ago

@MohitMaliDeveloper @mgautierfr ?

mgautierfr commented 1 year ago

I see that someone has uploaded binaries to https://search.maven.org/artifact/org.kiwix.libkiwix/libkiwix. Who has done this and how?

It is not me.

I wonder as well if it should not be better org.kiwix/libkiwix instead of org.kiwix.libkiwix/libkiwix?

Yes, I think so.

kelson42 commented 1 year ago

@MohitMaliDeveloper I need your feedback here

MohitMaliFtechiz commented 1 year ago

I see that someone has uploaded binaries to https://search.maven.org/artifact/org.kiwix.libkiwix/libkiwix. Who has done this and how?

I accidentally uploaded the artifact while testing the download of the staging artifact. This was a mistake since the release and drop options are positioned closely together and quite small. The release was not intentional.

I wonder as well if it should not be better org.kiwix/libkiwix instead of org.kiwix.libkiwix/libkiwix?

I believe that's a valid consideration since org.kiwix is the group id and libkiwix is the artifact id. It is good to use org.kiwix/libkiwix. We have released 1.0.0 for org.kiwix.libkiwix/libkiwix if we use org.kiwix/libkiwix then we can upload this new artifact with version 1.0.0.

kelson42 commented 1 year ago

@MohitMaliFtechiz Don't forget all the checkboxes in the ticket description!

kelson42 commented 1 year ago

@MohitMaliFtechiz published... but still not visible on MavenCentral... I guess it takes a few hours?!

MohitMaliFtechiz commented 1 year ago

@MohitMaliFtechiz published... but still not visible on MavenCentral... I guess it takes a few hours?!

@kelson42 Now it is live on Maven https://mvnrepository.com/artifact/org.kiwix/libkiwix/1.0.0