Use libkiwix 12.0.0 - Githubissues

MohitMaliFtechiz commented 1 year ago

Fixes #43 We have now automatically set the version code of java-libkiwix on behalf of the libkiwix version, this change makes sure the version of the java-libkiwix same as the libkiwix version while releasing the java-libkiwix on maven.

kelson42 commented 1 year ago

@MohitMaliFtechiz use a fixed version!? Builds should be perfectly reproducable... your PT nakes things even worse.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c928e30) 92.65% compared to head (584a8b1) 92.65%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #44 +/- ## ========================================= Coverage 92.65% 92.65% Complexity 212 212 ========================================= Files 43 43 Lines 286 286 Branches 3 3 ========================================= Hits 265 265 Misses 18 18 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MohitMaliFtechiz commented 1 year ago

@kelson42, Apart from this PR, currently we have a fixed version for java-libkiwix.

ext {
    set("GROUP_ID", "org.kiwix.kiwixlib")
    set("ARTIFACT_ID", "kiwixlib")
    set("VERSION", "11.0.0")
}

set("VERSION", "11.0.0") Here we just need to change the version code before releasing the libkiwix.

@MohitMaliFtechiz use a fixed version!? Builds should be perfectly reproducable... your PT nakes things even worse.

My bad I did this to automate the process, apart from this if need to use a fixed version then IMO we can stick with this because adding a new variable for this will not be a good idea which is already a fixed value. We can add a comment here to properly understand what this version does.

kelson42 commented 1 year ago

@MohitMaliFtechiz For sure... then why you told me the release was using latest nightly?! Now please implement my ticket to release 12.0.0.

kelson42 commented 1 year ago

@MohitMaliFtechiz Look like a fix to #42. Please update the description and changelog. Libkiwix changelog should be chexked to see what are the changes inthe ABI 12.0.0

MohitMaliFtechiz commented 1 year ago

@MohitMaliFtechiz For sure... then why you told me the release was using latest nightly?! Now please implement my ticket to release 12.0.0.

I think there is some misunderstanding. here I meant for the latest nightly we are using the latest .so files which come from the nightly. Suppose if currently nightly returning the .so files of 12.0.0 then it now release binary with those .so files, However, whatever the version of java-libkiwix. We have released the libkiwix 12.0.0 on 30 Nov https://github.com/kiwix/libkiwix/releases. So while releasing the java-libkiwix 11.0.0 it used the newly available .so files which come from nightly (which was libkiwx = 12.0.0, libzim = 8.2.0).

Now please implement my ticket to release 12.0.0.

If we release the java-libkiwix now, then the only change is available there which we have fixed in https://github.com/kiwix/java-libkiwix/pull/40, However, we are currently facing some issues in search and sever, so it would be better to fix those issues first. If they are from the java-libkiwix end, then this releasing not make sense, so it would be better to wait to fix those issues before releasing the new version of java-libkiwix.

Let me know if my explanation makes sense to you.

kiwix / java-libkiwix

Use libkiwix 12.0.0 #44

Codecov Report