Moving `java-libkiwix` to the new Maven repository with version code `1.0.0`

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin

https://central.sonatype.com/artifact/org.kiwix/libkiwix

GNU General Public License v3.0

3 stars 4 forks source link

Moving `java-libkiwix` to the new Maven repository with version code `1.0.0` #45

Closed MohitMaliFtechiz closed 1 year ago

MohitMaliFtechiz commented 1 year ago

Fixes #43

According to the conversation https://github.com/kiwix/java-libkiwix/issues/43#issuecomment-1639588336 we are moving our java-libkiwix to the new maven repo org.kiwix.libkiwix with version code 1.0.0.
Updated the source of libkiwix and libzim .so files from download.kiwix.org/release instead of using nightly builds.
Introduced new variables for specifying the versions of libkiwix and libzim, to make the dynamic URL that retrieves the .so files from the release repositories.
Modified the README.md file to emphasize the importance of updating the version before building the bindings.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c928e30) 92.65% compared to head (ebd27b5) 92.65%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================= Coverage 92.65% 92.65% Complexity 212 212 ========================================= Files 43 43 Lines 286 286 Branches 3 3 ========================================= Hits 265 265 Misses 18 18 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kelson42 commented 1 year ago

@MohitMaliFtechiz I was not expecting instructions in Readme.md.... but update of badge code...

MohitMaliFtechiz commented 1 year ago

@kelson42, I have updated the badge code in the README.md file. Currently, it will show as "not found" (https://img.shields.io/maven-central/v/org.kiwix.libkiwix/libkiwix) because we have not yet published the artifact on Maven. Once we publish the artifact on Maven, it will start displaying correctly in the badge.

kelson42 commented 1 year ago

@MohitMaliFtechiz What is left to do on Maven, on Github, to be able to publish under this new name?

MohitMaliFtechiz commented 1 year ago

@MohitMaliFtechiz What is left to do on Maven, on Github, to be able to publish under this new name?

@kelson42, We don't need to make any changes on Maven or GitHub. We can directly publish the artifact using the current CI with this new name. I have already attempted to publish the artifact with this new name to test if there are any additional requirements after changing the artifact name. It was successfully uploaded to Maven as a draft (which has since been removed).