search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Fix typo in setDataDirectory. #48

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

This is libkiwix, not kiwixlib.

Fix #47

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.27 :warning:

Comparison is base (ebd27b5) 92.65% compared to head (020c937) 92.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ============================================ - Coverage 92.65% 92.38% -0.27% - Complexity 212 213 +1 ============================================ Files 43 44 +1 Lines 286 289 +3 Branches 3 3 ============================================ + Hits 265 267 +2 - Misses 18 19 +1 Partials 3 3 ``` | [Impacted Files](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix) | Coverage Δ | | |---|---|---| | [...b/src/test/org/kiwix/test/libkiwix/TestJNIICU.java](https://app.codecov.io/gh/kiwix/java-libkiwix/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kiwix#diff-bGliL3NyYy90ZXN0L29yZy9raXdpeC90ZXN0L2xpYmtpd2l4L1Rlc3RKTklJQ1UuamF2YQ==) | `66.66% <66.66%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kelson42 commented 1 year ago

@mgautierfr This should be part of the automated test set.

mgautierfr commented 1 year ago

This is done in this PR

kelson42 commented 1 year ago

@mgautierfr OK, Mohit is off for the moment, might take days. But if tested correctly, we can merge IMO.